Make sure CI tests failed with detailed error stack when there are testbook failures - #438
Merged
Conversation
…tware/QMCSoftware into geometric_brownian_motion
This reverts commit aeb3d5c.
This reverts commit 3b3f795.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the CI testing infrastructure to ensure testbook failures produce detailed error output and proper exit codes, preventing silent test failures in CI environments.
Key changes:
- Enhanced error reporting in parallel test runner with detailed log output on failures
- Added proper exit code handling to fail CI builds when tests fail
- Refactored GBM notebook tests with improved symlink handling and execution patterns
Reviewed changes
Copilot reviewed 26 out of 37 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
test/booktests/parsl_test_runner.py |
Added detailed error logging (printing last 2000 chars of logs), proper sys.exit() calls to fail CI on errors, and exit code checking for failed tests |
test/booktests/__init__.py |
Added helper methods for notebook location and execution, reorganized imports |
test/booktests/tb_gbm_examples.py |
Implemented symlink fixing utility and custom notebook execution with directory context switching |
test/booktests/tb_gbm_demo.py |
Added skip decorator referencing GitHub issue, refactored to use new helper functions |
test/booktests/tb_MCQMC_2020_QMC_Software_Tutorial.py |
Added skip decorator to temporarily disable tests |
test/booktests/tb_why_add_q_to_mc_blog.py |
Added setUp method to create outputs directory before test execution |
test/booktests/READEME.md |
Added documentation on design patterns for testbook usage |
pyproject.toml |
Added test dependencies: pandas, yfinance, quantlib, ipywidgets, nbconvert |
.github/workflows/booktests.yml |
Added pyproject.toml to trigger paths and type1cm LaTeX package |
demos/GBM/** |
Added type hints to utility functions, refactored MAE computation, fixed symlink paths from code/ to gbm_code/, added new demo scripts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
|
@sou-cheng-choi I've opened a new pull request, #442, to work on those changes. Once the pull request is ready, I'll request review from you. |
…documentation (#442) * Initial plan * Fix typo and remove unused imports Co-authored-by: sou-cheng-choi <18743024+sou-cheng-choi@users.noreply.github.com> * Clarify comment in tb_gbm_demo.py Co-authored-by: sou-cheng-choi <18743024+sou-cheng-choi@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sou-cheng-choi <18743024+sou-cheng-choi@users.noreply.github.com>
alegresor
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.