Delete the two migrated copies, now that every site is republished - #836
Merged
Conversation
Phase 2 of wave A4. #834 repointed the reads and kept the files; this removes them, now that nothing anywhere reads them. lectures/_static/lecture_specific/simple_linear_regression/ life-expectancy-vs-gdp-per-capita.csv (2,059,709 B) lectures/_static/lecture_specific/inequality/ usa-gini-nwealth-tincome-lincome.csv (1,268 B) Both now live at raw.githubusercontent.com/QuantEcon/data-lectures/main/lectures/, byte-identical (sha256 ec5d3235… / bed9074a…) and CI-hash-checked there on every PR. The bytes are not lost. data.ipynb is KEPT. It is a notebook, not a dataset; inequality.md:618 links to it as a reader-facing artifact, and that link is untouched. A frozen copy also landed in data-lectures as the dataset's provenance record, but this is the copy readers open. (It does not run under the pinned pandas 3 — that is #835, and deliberately not fixed here.) THE GATE, which is four publishes and not one. Merging a repoint changes `main`, not a published site: intro, lecture-intro.zh-cn and the canary all publish on a `publish*` tag. Skipping this is what QuantEcon/workspace-lectures#28 recorded, and this time there is real deletion behind it. All four are now republished, and every published artifact was re-fetched and grepped: intro.quantecon.org slr + inequality, .html and _notebooks/*.ipynb 0 lecture-intro.zh-cn same four artifacts 0 test-actions-lecture-intro both pages -> 404 (trimmed toc; verify by 404, not by content, since deploy-pages replaces the whole artifact) 0 lecture-wasm /simple-linear-regression (hyphenated slug; its inequality is commented out of myst.yml) 0 lecture-python-intro.notebooks refreshed 4s inside intro's publish run 0 ORG SWEEP, re-run at deletion time rather than carried from an earlier snapshot. 277 repos via the Trees API including all 25 archived ones — `gh search code` does not index archived repos, which is how two `.rst` ancestors were missed in an earlier sweep of a different file. One error, QuantEcon/quantecon-book-dp, which is empty. No truncated trees. Path hits are only data-lectures' migrated copies and the three remaining mirror-orphans; an authenticated tarball content grep over the eight plausible consumers returns ZERO references to these paths, with a positive control against the pre-repoint tree returning 3. Left deliberately: lecture-intro.zh-cn and test-actions-lecture-intro still hold their own byte-identical copies. Nothing reads them either, but they are outside the audit's SCAN_REPOS so deleting them moves no dashboard number, and each adds blast radius to a repo with no CI coverage of these files. They are Track X. lecture-wasm's two were deleted in its own repoint PR, where the audit does see the change. The `_static/lecture_specific/simple_linear_regression/` directory becomes empty and disappears; nothing references it. `_config.yml` and `_toc.yml` never named either file.
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes two previously migrated CSV assets from lecture-python-intro now that all published sites have been repointed and republished to read the byte-identical copies from QuantEcon/data-lectures.
Changes:
- Delete the local copy of
life-expectancy-vs-gdp-per-capita.csvfrom thesimple_linear_regressionlecture static assets. - Delete the local copy of
usa-gini-nwealth-tincome-lincome.csvfrom theinequalitylecture static assets.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lectures/_static/lecture_specific/simple_linear_regression/life-expectancy-vs-gdp-per-capita.csv | Removes the now-unused local CSV after repointing reads/downloads to data-lectures. |
| lectures/_static/lecture_specific/inequality/usa-gini-nwealth-tincome-lincome.csv | Removes the now-unused local CSV after repointing reads to data-lectures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of wave A4. #834 repointed the reads and kept the files; this removes them, now that nothing anywhere reads them.
lectures/_static/lecture_specific/simple_linear_regression/life-expectancy-vs-gdp-per-capita.csvlectures/_static/lecture_specific/inequality/usa-gini-nwealth-tincome-lincome.csvBoth now live at
raw.githubusercontent.com/QuantEcon/data-lectures/main/lectures/, byte-identical (ec5d3235…/bed9074a…) and hash-checked by CI there on every PR. The bytes are not lost.data.ipynbis kept. It is a notebook, not a dataset;inequality.md:618links to it as a reader-facing artifact and that link is untouched. A frozen copy also landed in data-lectures as the dataset's provenance record, but this is the copy readers actually open. (It does not run under the pinned pandas 3 — that is #835, deliberately not fixed here.)The gate is four publishes, not one
Merging a repoint changes
main, not a published site — intro,lecture-intro.zh-cnand the canary all publish on apublish*tag. Skipping that is exactly what QuantEcon/workspace-lectures#28 recorded, and this time there is real deletion behind it. All four are now republished, and every published artifact was re-fetched and grepped:intro.quantecon.org— slr + inequality,.htmland_notebooks/*.ipynblecture-intro.zh-cn— the same fourtest-actions-lecture-intro— both pageslecture-wasm—/simple-linear-regressionlecture-python-intro.notebooksTwo things that would have produced a false pass. The canary's pages 404 rather than update —
only_build_toc_files: trueplus a trimmed_toc.yml, anddeploy-pagesreplaces the whole artifact, so verify by 404 and not by content. Andlecture-wasmserves hyphenated slugs (/simple-linear-regression); checking/simple_linear_regression.htmlreturns a 404 body that greps clean and looks like a pass.Org sweep, re-run at deletion time
Not carried from an earlier snapshot — this is the rule that binds here.
gh search codedoes not index archived repos, which is how two.rstancestors of a different file were missed in an earlier sweep.QuantEcon/quantecon-book-dp, which is empty. No truncated trees.77e553a) returns 3, so the clean result is a real zero.Left deliberately
lecture-intro.zh-cnandtest-actions-lecture-introstill hold their own byte-identical copies. Nothing reads those either, but they sit outside the audit'sSCAN_REPOS, so deleting them moves no dashboard number while adding blast radius to two repos with no CI coverage of these files. They are Track X.lecture-wasm's two were deleted in its own repoint PR, where the audit does see the change.The
_static/lecture_specific/simple_linear_regression/directory becomes empty and disappears; nothing references it, and neither_config.ymlnor_toc.ymlever named either file.Tracking: QuantEcon/workspace-lectures#23