Delete the five wave B1' data files now they are migrated and published - #1035
Merged
Conversation
Phase 2 of the repoint. These five now live in QuantEcon/data-lectures and every consumer reads them from there: lectures/_static/lecture_specific/ols/maketable1.dta lectures/_static/lecture_specific/ols/maketable2.dta lectures/_static/lecture_specific/ols/maketable4.dta lectures/_static/lecture_specific/mle/fp.dta lectures/_static/lecture_specific/phillips_drifts_volatilities/NEWQDATA.csv Deliberately split from the repoint (#1034) rather than bundled with it. This repo publishes on a `publish* tag`, so the already-published notebooks kept the old URLs until the site refreshed; deleting in the same PR would have 404'd every reader who downloaded a lecture or opened it in Colab. The gate has now been met: publish-2026aug13 shipped, python.quantecon.org serves only data-lectures URLs, and lecture-python.notebooks regenerated clean. Exactly five files, never the parent directory. `_static/lecture_specific/` has 32 subdirectories in HEAD and 29 survive. Two of the survivors would have been silent breakage: hansen_singleton_1982/ and hansen_singleton_1983/ each hold a make_data.py that is still read at runtime by both this repo and lecture-python.zh-cn (wave B2'), and linear_algebra/course_notes.pdf plus linear_models/iteration_notes.pdf are linked from the published PDF, from lecture-python.zh-cn and from tom-course-2025's Pages site. The three directories that do disappear held only the deleted files. An org-wide sweep cleared this: 277/277 repos plus 38 Pages-source branches, 51 course/workshop/canary repos individually checked, outside-org forks and GitHub-wide code search, then an adversarial pass that reproduced every control from scratch. Nothing executable breaks anywhere, in or outside the org -- every read now points either at data-lectures or at an archived QuantEcon repo holding its own byte-identical copy. The known residual is three third-party course sites whose prose download link for fp.dta will 404 (mcherculano/ECON5129, quecheny/quecheny, elliottserna/econometrics). Their notebooks keep working: their executable reads point at the archived QuantEcon/lecture-python, which this migration does not touch. Recorded rather than fixed -- QuantEcon cannot edit those repos. Not irreversible: the bytes stay in this repo's history, exist byte-identically in ten other repos, and every publish cuts a full-site release asset. Part of QuantEcon/workspace-lectures#39. Data landed in QuantEcon/data-lectures#79 and flipped in #80. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the now-redundant Wave B1′ static data blobs from this repo after consumers were repointed to QuantEcon/data-lectures and the publish gate was met, reducing repository bloat and avoiding duplicate sources of truth.
Changes:
- Delete five migrated dataset files under
lectures/_static/lecture_specific/(ols/,mle/,phillips_drifts_volatilities/). - Remove the now-empty
lecture_specificsubdirectories that only contained those deleted files.
Reviewed changes
Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
lectures/_static/lecture_specific/ols/maketable1.dta |
Deleted migrated OLS dataset now served from QuantEcon/data-lectures. |
lectures/_static/lecture_specific/ols/maketable2.dta |
Deleted migrated OLS dataset now served from QuantEcon/data-lectures. |
lectures/_static/lecture_specific/ols/maketable4.dta |
Deleted migrated OLS dataset now served from QuantEcon/data-lectures. |
lectures/_static/lecture_specific/mle/fp.dta |
Deleted migrated MLE dataset now served from QuantEcon/data-lectures. |
lectures/_static/lecture_specific/phillips_drifts_volatilities/NEWQDATA.csv |
Deleted migrated Phillips dataset now served from QuantEcon/data-lectures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
📖 Netlify Preview Ready!Preview URL: https://pr-1035--sunny-cactus-210e3e.netlify.app Commit: Build Info
|
mmcky
added a commit
to QuantEcon/data-lectures
that referenced
this pull request
Aug 13, 2026
Adds a fourth ordering trap. The existing third rule — "repoint, publish, then delete" — gets the ordering right but implies the delete step takes effect when it merges and publishes. It does not. `ci.yml` and `publish.yml` in lecture-python.myst both restore the `build-cache` artifact from `cache.yml` and build over it. Sphinx copies html_static_path into _build/html/_static but never prunes assets removed from source, so a deleted _static file survives in the restored tree and is deployed again. Only `cache.yml` builds from a clean checkout, and it runs weekly. Measured, not inferred: PR QuantEcon/lecture-python.myst#1035 deletes five data files, and its preview build served all five at HTTP 200 with the correct content-type and byte count, from a branch that does not contain them. A never-existed control path returned 404 on the same host, so this is not a Netlify SPA-fallback false pass. The consequence is a false completion rather than breakage: files keep resolving, which is strictly safer, but the repo, migration.yml and CATALOG.md all read "deleted" while readers still get the old bytes. Hence the rule's operative half — verify a deletion against the published URL, never against main. Scope beyond lecture-python.myst is still being established; the rule names the repo it was measured in rather than generalising ahead of the evidence. Part of QuantEcon/workspace-lectures#39. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of wave B1′. These five files now live in
QuantEcon/data-lecturesand every consumer reads them from there, so the copies here are retired.lectures/_static/lecture_specific/ols/maketable1.dtalectures/_static/lecture_specific/ols/maketable2.dtalectures/_static/lecture_specific/ols/maketable4.dtalectures/_static/lecture_specific/mle/fp.dtalectures/_static/lecture_specific/phillips_drifts_volatilities/NEWQDATA.csvWhy this is a separate PR from the repoint
This repo publishes on a
publish*tag, so the already-published notebooks kept the old URLs until the site refreshed. Deleting in the same PR as #1034 would have 404'd every reader who downloaded a lecture or opened one in Colab — and nothing would have alerted us: rendered HTML is unaffected because figures are baked at build time, repo CI would pass, and a link checker over the live site would be checking the stale-but-valid old build.The gate has been met.
publish-2026aug13shipped;python.quantecon.org/{ols,mle,phillips_drifts_volatilities}.htmlnow serve onlydata-lecturesURLs with zero stale references;lecture-python.notebooksregenerated at 02:59 carrying 5/2/1 new URLs and zero old ones. The same is true forlecture-python.zh-cn(site and its_notebooks/tree) and forlecture-stats.Exactly five files, never the parent directory
_static/lecture_specific/has 32 subdirectories in HEAD; 29 survive. The three that disappear (ols/,mle/,phillips_drifts_volatilities/) held only the deleted files — verified before deleting.Two survivors would have been silent, real breakage if this had been done by removing the parent:
hansen_singleton_1982/andhansen_singleton_1983/each hold amake_data.pythat is still read at runtime, by this repo and bylecture-python.zh-cn, via the same wrappedlecture-python.myst/raw/refs/heads/main/URL form. They are wave B2′ scope and are deliberately untouched here.linear_algebra/course_notes.pdfandlinear_models/iteration_notes.pdfare linked from the published PDF, fromlecture-python.zh-cn, and fromtom-course-2025's Pages site.The sweep behind this
277/277 org repos (68 private, 25 archived) plus 38 Pages-source branches; 51 course/workshop/canary repos enumerated by name pattern and individually checked on both default and
gh-pagesbranches; outside-org forks with counts cross-checked againstforks_count; GitHub-wide code search; then an adversarial pass that reproduced every positive control from scratch and added six spot checks of its own — including zlib-decompressing the published PDF's 275 URI annotations, sincestringson a compressed PDF is a false-clean waiting to happen.Nothing executable breaks anywhere, in or outside the org. Every
read_stata/read_csvin the world now points either atdata-lectures(repointed, 200) or at an archived QuantEcon repo holding its own byte-identical copy — verified by sha256, not asserted. Course forks and canaries: zero hits on all five files.Known residual, recorded rather than fixed
Three third-party course sites carry a prose "download here" link to
python.quantecon.org/_static/lecture_specific/mle/fp.dta, which will 404 after this merges and republishes:mcherculano/ECON5129,quecheny/quecheny,elliottserna/econometrics(all confirmed live today). Their notebooks keep working — their executable reads point at the archivedQuantEcon/lecture-python, which this migration does not touch. QuantEcon cannot edit those repos.maketable1/2/4.dtaandNEWQDATA.csvhave zero external references of any kind; the entire residual isfp.dta.The one in-org equivalent,
lecture-mapping, is being repointed separately.Not irreversible
Deletion is a commit, not a history rewrite. The bytes remain in this repo's history, exist byte-identically in ten other repositories, and every publish cuts a full-site release asset (
lecture-python-html-publish-*.tar.gz) that includes_static. Restoring is a revert plus a republish.Part of QuantEcon/workspace-lectures#39. Data landed in QuantEcon/data-lectures#79 and flipped in #80; the repoint was #1034.
🤖 Generated with Claude Code