Delete the migrated hansen_singleton data and builders (wave B2', phase 2) - #1037
Merged
Conversation
…se 2) Six files across two directories: both CSVs, both make_data.py, and both READMEs. All now live in QuantEcon/data-lectures, where the builders were renamed to their dataset stems and each README's content was folded into its manifest. Gate satisfied. Nothing reads these: * both lectures here repointed in #1036, merged and published * both lecture-python.zh-cn twins repointed in QuantEcon/lecture-python.zh-cn#250, merged and published * lecture-python.notebooks regenerated at 09:34:21Z and both notebooks carry the data-lectures URL * migration.yml flipped to `repointed` in QuantEcon/data-lectures#83, strict audit green Swept the org rather than the manifest. These files were created 2026-06-26 (a3e8443, #926), so only repos pushed since can reference them: 88 of the org's 277, swept by Trees API, zero unreadable. Exactly four hold any hansen_singleton path — this repo, zh-cn, data-lectures and the notebooks mirror. zh-cn's copies are its own committed blobs, not reads of these, and its lectures now read data-lectures; they are Track X orphans and are deliberately left alone. Deletes exactly six files, not the parent directories' 29 siblings. `hansen_singleton_198{2,3}/` held nothing else, tracked or untracked; 27 sibling directories under lecture_specific/ are untouched, including linear_algebra/ and linear_models/, whose PDFs are linked from the published site. NOTE: this will not stop the site serving them. Both ci.yml and publish.yml restore the weekly build-cache and build over it, and Sphinx never prunes removed _static assets — measured on this repo today, where wave B1's five deleted files were still served at 200 after a successful publish three hours later. The files stop being served after cache.yml rebuilds clean (Mon 03:00 UTC) and a publish follows, which will settle B1' and B2' together. Verify against the published URL with a never-existed control, never against main. Cause and fix: QuantEcon/workspace-lectures#41 Verification sweep: QuantEcon/workspace-lectures#40 Mirrors the wave in QuantEcon/data-lectures#82 Work plan: QuantEcon/workspace-lectures#39 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the Hansen–Singleton (1982/1983) vendored datasets and their local maintenance builders/READMEs from this lecture repository, completing phase 2 of the migration to QuantEcon/data-lectures after the lectures were repointed.
Changes:
- Deletes the two vendored CSV datasets under
lectures/_static/lecture_specific/. - Deletes the two local dataset builder scripts (
make_data.py) that generated those CSVs. - Deletes the two per-dataset README files whose content has been moved into the destination dataset manifests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lectures/_static/lecture_specific/hansen_singleton_1982/hansen_singleton_1982_data.csv | Remove migrated 1982 CSV from this repo. |
| lectures/_static/lecture_specific/hansen_singleton_1982/make_data.py | Remove migrated 1982 builder script from this repo. |
| lectures/_static/lecture_specific/hansen_singleton_1982/README.md | Remove migrated 1982 dataset README from this repo. |
| lectures/_static/lecture_specific/hansen_singleton_1983/hansen_singleton_1983_data.csv | Remove migrated 1983 CSV from this repo. |
| lectures/_static/lecture_specific/hansen_singleton_1983/make_data.py | Remove migrated 1983 builder script from this repo. |
| lectures/_static/lecture_specific/hansen_singleton_1983/README.md | Remove migrated 1983 dataset README from this repo. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
📖 Netlify Preview Ready!Preview URL: https://pr-1037--sunny-cactus-210e3e.netlify.app Commit: Build Info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of wave B2′ — removes the six files migrated to
QuantEcon/data-lecturesin QuantEcon/data-lectures#82. Work plan: QuantEcon/workspace-lectures#39._static/lecture_specific/hansen_singleton_1982/hansen_singleton_1982_data.csvdata-lectureslectures/hansen_singleton_1982_data.csv…/hansen_singleton_1982/make_data.pydata-lecturesbuilders/hansen_singleton_1982_data.py…/hansen_singleton_1982/README.md_static/lecture_specific/hansen_singleton_1983/hansen_singleton_1983_data.csvdata-lectureslectures/hansen_singleton_1983_data.csv…/hansen_singleton_1983/make_data.pydata-lecturesbuilders/hansen_singleton_1983_data.py…/hansen_singleton_1983/README.mdThe builders were renamed to their dataset stems because both were called
make_data.pyand collide in a flatbuilders/tree. Each README's content becamesource,schema.columns[].descriptionandintegrity.upstream.notein its manifest, plus the module docstring.Gate — nothing reads these
publish-2026aug13b)lecture-python.zh-cntwins repointed in 🌐 [translation-sync] Repoint the hansen_singleton pair at QuantEcon/data-lectures (wave B2') lecture-python.zh-cn#250, merged and publishedlecture-python.notebooksregenerated at 09:34:21Z; both notebooks carry thedata-lecturesURL and zerolecture_specificreferencesmigration.ymlflipped torepointedin Flip wave B2' to repointed — the hansen_singleton pair (Track B) data-lectures#83, strict audit greenThe sweep was org-wide, and it used the files' age to make that cheap
manifest.ymlis the authoring scope, not the consumer scope, so a sweep over the clones here is not org-wide. But these files were created 2026-06-26 (a3e8443, #926), which means only repos pushed since can possibly reference them — 88 of the organisation's 277. Swept those 88 by Trees API, zero unreadable.Exactly four repos hold any
hansen_singletonpath:lecture-python.zh-cnmake_data.pydata-lectures, not these. Deliberately left alonedata-lectureslecture-python.notebooksThe 189 repos pushed before 2026-06-26 are excluded by construction rather than by a grep that could return a false zero — including the archived ones that
gh search codecannot see at all, which predate these lectures by years.Two sweep traps worth recording, both hit live: the
while readloop silently dropped one repo becausecand.txt's last line had no trailing newline (wc -l87 vsgrep -c ''88) —QuantEcon/governance, swept separately, clean. And every grep in this sweep ran as/usr/bin/grepwith exit status checked against a positive control, becausegrepis a shell-function shim here and a bare call from a script reports a confident clean zero.Scope — six files, not two directories' worth of neighbours
hansen_singleton_1982/andhansen_singleton_1983/held nothing else, tracked or untracked. The 27 remaining sibling directories under_static/lecture_specific/are untouched — includinglinear_algebra/course_notes.pdfandlinear_models/iteration_notes.pdf, which are linked from the published PDF and from third-party course sites, and would be silent, real breakage.This will not stop the site serving them, and that is expected
Both
ci.ymlandpublish.ymlrestore the weeklybuild-cacheartifact and build over it, and Sphinx never prunes_staticassets removed from source. Measured on this repo today: wave B1′'s five deleted files were still served at HTTP 200, with correct content-types and exact byte counts, after a successful publish three hours after their deletion merged — so publish lag is not the explanation. Controls in the same pass 404'd a never-existed path.These six will behave the same way. They stop being served after
cache.ymlrebuilds clean (Mon 2026-08-17 03:00 UTC) and a publish follows — one publish settles B1′ and B2′ together. To close it sooner,workflow_dispatchcache.ymland let it finish before tagging.Verify this deletion against the published URL with a never-existed control path, never against
main. The repo,migration.ymlandCATALOG.mdwill all say "deleted" while readers still get the bytes.Cause and fix: QuantEcon/workspace-lectures#41 · Verification sweep: QuantEcon/workspace-lectures#40 · The ordering rule: QuantEcon/data-lectures#81
🤖 Generated with Claude Code