Skip to content

test(theme): querya.theme.v1 parser fixtures (#97) - #128

Merged
ZhuchkaTriplesix merged 1 commit into
issue/96-theme-custom-json-schemafrom
issue/97-theme-json-fixtures
Jun 13, 2026
Merged

test(theme): querya.theme.v1 parser fixtures (#97)#128
ZhuchkaTriplesix merged 1 commit into
issue/96-theme-custom-json-schemafrom
issue/97-theme-json-fixtures

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • Add stable test fixtures for the custom theme parser epic:
    • querya_custom_dark.json / querya_custom_light.json — full themes with distinct values
    • querya_custom_minimal.json — small required-field subset
    • querya_custom_invalid_missing_id.json — missing id
    • querya_custom_invalid_color.json — invalid optional colors
    • querya_custom_jsonc.jsonc — comments and trailing commas

Test plan

  • All .json fixtures parse with json.loads
  • JSONC fixture follows existing JSONC test pattern (stripped before parse in code)

Depends on #127 (TP-01 docs). Merge #127 first, then re-target this PR to dev if needed.

Closes #97

Add dark, light, minimal, invalid, and JSONC theme files for upcoming manifest
and factory tests. Closes #97.
@github-actions github-actions Bot added good first issue Good for newcomers theme Theming, colors, VS Code themes tests Theme parser epic labels Jun 13, 2026
@github-actions github-actions Bot added this to the Theme system milestone Jun 13, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit d6729e8 into issue/96-theme-custom-json-schema Jun 13, 2026
1 check passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/97-theme-json-fixtures branch June 15, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers tests Theme parser epic theme Theming, colors, VS Code themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant