Skip to content

feat(theme): QueryaThemeManifest parser (#98) - #129

Merged
ZhuchkaTriplesix merged 4 commits into
devfrom
issue/98-querya-theme-manifest
Jun 13, 2026
Merged

feat(theme): QueryaThemeManifest parser (#98)#129
ZhuchkaTriplesix merged 4 commits into
devfrom
issue/98-querya-theme-manifest

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • Add QueryaThemeManifest / QueryaThemeType for querya.theme.v1 JSON and JSONC files.
  • Reuse existing stripJsonc and TokenColorRule parsing; keep color maps as unmodifiable strings (no Color / ThemeData yet).
  • Include TP-02 fixtures (cherry-picked; supersedes open test(theme): querya.theme.v1 parser fixtures (#97) #128 if still pending).
  • Add parser unit tests against dark/light/minimal/JSONC/invalid fixtures.

Test plan

  • flutter test test/core/theme/parser/querya_theme_manifest_test.dart
  • CI flutter analyze + full test suite

Closes #98

If #128 is still open, close it after merge — fixtures are included here.

Add dark, light, minimal, invalid, and JSONC theme files for upcoming manifest
and factory tests. Closes #97.
Parse querya.theme.v1 JSON/JSONC into an immutable manifest with shadcn/editor
color maps and tokenColors, without building Flutter Color objects yet.
Cover valid fixtures, JSONC, empty color maps, validation errors, and
unmodifiable maps. Closes #98.
@github-actions github-actions Bot added theme Theming, colors, VS Code themes parser Theme parser epic label: parser labels Jun 13, 2026
@github-actions github-actions Bot added this to the Theme system milestone Jun 13, 2026

@ZhuchkaTriplesix ZhuchkaTriplesix left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

123

Use const for the static QueryaThemeManifestParseException message.
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit be379d0 into dev Jun 13, 2026
3 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/98-querya-theme-manifest branch June 15, 2026 04:13
ZhuchkaTriplesix added a commit that referenced this pull request Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parser Theme parser epic label: parser theme Theming, colors, VS Code themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant