fix(router): action redirects#8780
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 418fed6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
There was a problem hiding this comment.
Pull request overview
Fixes Qwik Router “action redirect” behavior for JSON action submissions by returning a JSON redirect envelope (instead of an HTTP 3xx that fetch would auto-follow) and teaching the client router to navigate when that envelope is received.
Changes:
- Convert action redirects caught by
jsonRequestWrapper()into a JSON action response containing{ redirect: <url> }. - Update client-side action handling to call
goto()when the action response includesredirect. - Add e2e coverage and a test route to validate both the JSON envelope shape and SPA navigation on redirect.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/qwik-router/src/runtime/src/qwik-router-component.tsx | Trigger client navigation when an action result includes a redirect field. |
| packages/qwik-router/src/middleware/request-handler/handlers/json-request-wrapper.ts | Serialize action redirects as JSON (avoids fetch auto-following 3xx). |
| e2e/qwik-e2e/tests/qwikrouter/returned-control-flow.e2e.ts | Adds regression tests for JSON action redirect envelope + SPA navigation. |
| e2e/qwik-e2e/apps/qwikrouter-test/src/routes/returned-control-flow/action-redirect/index.tsx | Adds a routeAction-based redirect fixture for the new e2e tests. |
| .changeset/goofy-doodles-decide.md | Adds a changeset for the router behavior change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
68f49ab to
418fed6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.