fix: preserve transitive server$ modules in SSR builds#8818
Merged
Conversation
🦋 Changeset detectedLatest commit: 572f492 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
@qwik.dev/devtools
commit: |
a40dcf2 to
5316382
Compare
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SSR server function registration when server$ is only reachable through stripped client-side code or transitive imports. The router now preserves discovered server function modules through tree-shaking, including packages marked with sideEffects: false.
Examples:
Fixed path:
route -> product-page -> emit-view-content -> server$
2. server$ only used inside stripped client code
Before, SSR stripping removed the visible task usage, so the import could disappear from the SSR graph.
Before, the literal dynamic import was lost when useVisibleTask$ was stripped from SSR.
Before, the router generated only:
import './emit-view-content';
Rollup could tree-shake that away. Now it keeps the module exports live.