feat(core): PublicError — user-facing errors render unredacted through ErrorBoundary - #8868
Merged
Merged
Conversation
…ibling, resumed instanceof
🦋 Changeset detectedLatest commit: db955b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
@qwik.dev/devtools
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
15 intended reds form the red-proof baseline for the stateless redesign; e2e additions are green preservation pins.
…tore shape Raw in-memory storage makes the store a black box for hostile values; the display membrane is what guarantees an Error. Cyclic and toString-trap rows cannot both stay raw and be instanceof Error.
The qErr DOM script owns the errored end state; live styles subscribed to store.error would un-hide inert content after a stateless resume.
github-project-automation
Bot
moved this from Waiting For Review
to Done
in Qwik Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Adds
PublicError(from the error-rework RFC): throwing one under an<ErrorBoundary>shows its message and.datain the fallback unredacted, even in production — constructing it is the consent. Everything else keeps the fail-closed generic redaction.Class identity survives resume without a new serdes TypeId: a reserved marker pair inside the ordinary Error payload restores the prototype on inflate, so plain
instanceof PublicErrorworks everywhere (pinned by a prod e2e that probes the deserialized error in the browser).transformErrorstill runs first and wins.Based on #8745 — retarget to
mainonce that merges.