fix(qwik): emit valid @__PURE__ annotations from the minified dist build - #8908
Merged
Conversation
🦋 Changeset detectedLatest commit: cbbfaed The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
@qwik.dev/devtools
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Terser moved annotations away from the calls they belong to, so bundlers could not attach them and dropped the hints — 6 INVALID_ANNOTATION on the dist output, now 0.
maiieul
force-pushed
the
chore/dist-build-esbuild-minify
branch
from
August 4, 2026 04:35
ee8e607 to
cbbfaed
Compare
Varixo
approved these changes
Aug 5, 2026
github-project-automation
Bot
moved this from Waiting For Review
to Done
in Qwik Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Terser moves some
__PURE__annotations away from the call they belong to, so bundlers can'tattach them and silently drop the hint. Bundling our dist with rolldown reports 6
INVALID_ANNOTATIONtoday and 0 after this change, which means apps get the tree-shaking thoseannotations were supposed to buy. Same approach as #8379: keep terser and repair the two patterns
it strands — an annotation hoisted in front of a
return, and one left in front of a"" + fnconcatenation after terser rewrites
fn.toString(). Widened to match both the@and#spellings, since terser emits both. No size change; output is byte-for-byte main plus the repair.
Split out of #8785 so it can land on its own.