Housekeeping: remove dead modules-amdgcn, tidy CMake, refresh README#345
Merged
amontoison merged 2 commits intoJul 24, 2026
Merged
Conversation
- Remove lib/modules-amdgcn/ (legacy hand-written rocblas/rocsparse/hip_blas/rocfft modules — not built (commented out in CMake), unused, superseded by lib/hipfort/). - lib/CMakeLists.txt: drop the dead commented modules-amdgcn/nvptx/contrib globs and the empty source references; the library is built solely from lib/hipfort/. - README: interfaces are regenerated from the current ROCm (rocm-libraries), not ROCm 4.5.0; add hipFFTW to the supported-API list. - Add docs/doxygen/input/supported_api_hipfftw.md (70 interfaces).
amontoison
commented
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup pass on the build/docs after the binding regeneration:
rocblas,rocsparse,hip_blas,rocfft) were not compiled (commented out inlib/CMakeLists.txt), had zerousereferences, and are superseded by the generatedlib/hipfort/hipfort_*.F90.modules-amdgcn/modules-nvptx/modules-contribglobs and the empty source variables. The library is built solely fromlib/hipfort/.supported_api_hipfftw.md(70 interfaces) so the new README link resolves.