Skip to content

rsx: Implement support for extended-length vertex programs - #10501

Merged
kd-11 merged 2 commits into
RPCS3:masterfrom
kd-11:vulkan-updates
Jun 28, 2021
Merged

rsx: Implement support for extended-length vertex programs#10501
kd-11 merged 2 commits into
RPCS3:masterfrom
kd-11:vulkan-updates

Conversation

@kd-11

@kd-11 kd-11 commented Jun 27, 2021

Copy link
Copy Markdown
Contributor

Some games are kinda pushing it with RSX register space and spilling VP data into adjacent unused register space. This has some unexpected implications such as bumping the number of instruction addressing bits from 9 to 10 to cover the extended address space. This PR adds support for the extended size data as well as the results of the RE work to find the missing instruction bits. Due to this, the structure of the programs has changed and this requires a shader cache version bump.

Fixes #8500

- Some games are kinda pushing it with RSX register space and spilling VP data into adjacent unused space.
@SonofUgly

Copy link
Copy Markdown

Don't know if it's an issue with this, or was just exposed by this, but now there's some artifacts in Ratchet & Clank - Crack in Time (artifacts only happen on effects that were previously not rendered):
Black box around some effects
Mr. Zurkon's laser filling up the screen

@kd-11

kd-11 commented Jun 27, 2021

Copy link
Copy Markdown
Contributor Author

Don't know if it's an issue with this, or was just exposed by this, but now there's some artifacts in Ratchet & Clank - Crack in Time (artifacts only happen on effects that were previously not rendered):
Black box around some effects
Mr. Zurkon's laser filling up the screen

You need to enable Read Color Buffers to fix that and probably Write Color Buffers too while you're at it.

@SonofUgly

Copy link
Copy Markdown

You need to enable Read Color Buffers to fix that and probably Write Color Buffers too while you're at it.

Read Color Buffers fixes the black boxes, but nothing fixed Mr. Zurkon's laser (also noticed the light in his eyes are squares).

@kd-11

kd-11 commented Jun 27, 2021

Copy link
Copy Markdown
Contributor Author

The fix is for the missing draw calls, remaining issues need to be tracked separately.

@kd-11
kd-11 merged commit 2c7c1c5 into RPCS3:master Jun 28, 2021
@psennermann

Copy link
Copy Markdown

Btw is there any hope that #7076 will ever get fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ratchet & Clank: A Crack in Time [BCES00511] - Missing particles & effects

3 participants