Tiny Refactoring - #6143
Merged
2 commits merged intoJun 28, 2019
Merged
Conversation
elad335
force-pushed
the
ref
branch
3 times, most recently
from
June 28, 2019 16:55
f554ca2 to
381aa93
Compare
elad335
force-pushed
the
ref
branch
5 times, most recently
from
June 28, 2019 19:28
f7cb6d4 to
b5740c8
Compare
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Jun 29, 2019
ghost
pushed a commit
that referenced
this pull request
Jun 29, 2019
vm::spu max address was overflowing resulting in issues, so cast to u64 where needed. Fixes #6145. Use vm::get_addr instead of manually substructing vm::base(0) from pointer in texture cache code. Prefer std::atomic_thread_fence over _mm_?fence(), adjust usage to be more correct. Used sequantially consistent ordering in semaphore_release for TSX path as well. Improved memory ordering for sys_rsx_context_iounmap/map. Fixed sync bugs in HLE gcm because of not using atomic instructions. Use release memory barrier in lwsync for PPU LLVM, according to this xbox360 programming guide lwsync is a hw release memory barrier. Also use release barrier where lwsync was originally used in liblv2 sys_lwmutex and cellSync. Use acquire barrier for isync instruction, see https://devblogs.microsoft.com/oldnewthing/20180814-00/?p=99485
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vm::ptr<>::ptrovervm::get_addr.vm::_ptr/baseovervm::g_base_addrwith offset.atomic_t<>::btsandatomic_t<>::btr.rsx::thread::Read/WriteIO32methods.semaphore_release._mm_...in VPKSHUS ppu interpreter precise.io/sizealignment check forsys_rsx_context_iounmap.rsx::constants::local_mem_basewhich represents RSX local memory base address.rsx::thread::main_mem_addr/ioSize/ioAddressmembers.