Release/node/v0.5.3#120
Merged
Merged
Conversation
Optimize QUIC for high latency links
Keep permanent ADNL validator keys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the node’s QUIC transport behavior for better performance on high-latency links, and adjusts validator key rotation/cleanup to avoid removing still-referenced ADNL keys. It also bumps the node crate version to 0.5.3.
Changes:
- Switch QUIC transport to use BBR congestion control and remove the extra per-connection stream semaphore, relying on QUIC transport limits instead.
- Update validator key revision logic to keep ADNL keys when they’re still referenced by other elections (and adjust pruning threshold).
- Update
QuicNode::newcall sites for the constructor signature change, and bump versions.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/adnl/src/quic/mod.rs |
Removes user-level stream semaphore, adds BBR congestion controller config, logs UDP offload caps, and updates accept-loop signature accordingly. |
src/adnl/tests/test_quic.rs |
Updates tests for QuicNode::new signature and removes the old stream-semaphore-specific test. |
src/node/src/config.rs |
Revises validator key pruning and ADNL key cleanup to avoid removing ADNL keys still referenced by other elections; updates subscriber notification flow. |
src/node/src/network/node_network.rs |
Updates QUIC initialization call to match the new QuicNode::new signature. |
src/node/consensus-common/src/node_test_network.rs |
Updates QUIC initialization call to match the new QuicNode::new signature. |
src/node/tests/compat_test/src/test_helpers.rs |
Updates QUIC initialization call to match the new QuicNode::new signature. |
src/node/Cargo.toml |
Bumps node crate version to 0.5.3. |
src/Cargo.lock |
Updates lockfile to reflect the node version bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cleverfox
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed