Skip to content

Release/node/v0.5.3#120

Merged
bvscd merged 7 commits into
masterfrom
release/node/v0.5.3
Apr 23, 2026
Merged

Release/node/v0.5.3#120
bvscd merged 7 commits into
masterfrom
release/node/v0.5.3

Conversation

@bvscd
Copy link
Copy Markdown
Collaborator

@bvscd bvscd commented Apr 23, 2026

Changed

  • Optimize QUIC for high latency links
  • Keep permanent ADNL validator keys

Copilot AI review requested due to automatic review settings April 23, 2026 12:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the node’s QUIC transport behavior for better performance on high-latency links, and adjusts validator key rotation/cleanup to avoid removing still-referenced ADNL keys. It also bumps the node crate version to 0.5.3.

Changes:

  • Switch QUIC transport to use BBR congestion control and remove the extra per-connection stream semaphore, relying on QUIC transport limits instead.
  • Update validator key revision logic to keep ADNL keys when they’re still referenced by other elections (and adjust pruning threshold).
  • Update QuicNode::new call sites for the constructor signature change, and bump versions.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/adnl/src/quic/mod.rs Removes user-level stream semaphore, adds BBR congestion controller config, logs UDP offload caps, and updates accept-loop signature accordingly.
src/adnl/tests/test_quic.rs Updates tests for QuicNode::new signature and removes the old stream-semaphore-specific test.
src/node/src/config.rs Revises validator key pruning and ADNL key cleanup to avoid removing ADNL keys still referenced by other elections; updates subscriber notification flow.
src/node/src/network/node_network.rs Updates QUIC initialization call to match the new QuicNode::new signature.
src/node/consensus-common/src/node_test_network.rs Updates QUIC initialization call to match the new QuicNode::new signature.
src/node/tests/compat_test/src/test_helpers.rs Updates QUIC initialization call to match the new QuicNode::new signature.
src/node/Cargo.toml Bumps node crate version to 0.5.3.
src/Cargo.lock Updates lockfile to reflect the node version bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/node/src/config.rs
Comment thread src/adnl/src/quic/mod.rs
@bvscd bvscd merged commit fe02030 into master Apr 23, 2026
3 of 5 checks passed
@bvscd bvscd deleted the release/node/v0.5.3 branch April 23, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants