Fix Workshop autoexec command buffer overflow - #1085
Merged
Conversation
Only queue autoexec commands for Workshop addons that actually provide an autoexec_<id>.cfg file. Previously, every subscribed addon could enqueue an execifexists command, causing the engine's command buffer to overflow when many addons were subscribed. This could cause subsequent commands, such as quit, to be dropped. Check for the autoexec file before queuing the command and use exec directly once its existence has been confirmed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only queue autoexec commands for Workshop addons that actually provide an autoexec_.cfg file.
Previously, every subscribed addon could enqueue an execifexists command, causing the engine's command buffer to overflow when many addons were subscribed. This could cause subsequent commands, such as quit, to be dropped.
Check for the autoexec file before queuing the command and use exec directly once its existence has been confirmed.