Fix IllegalStateException in SchedulerToExecutorService.invokeAny#8159
Merged
akarnokd merged 1 commit intoJun 22, 2026
Conversation
invokeAny() guarded its result check with f.exceptionNow() == null, but Future.exceptionNow() throws IllegalStateException when the task completed normally (i.e. there is no exception), per its contract. As a result the first successfully completed task triggers an IllegalStateException instead of being returned. Both invokeAny overloads are affected. Replace the isDone/isCancelled/exceptionNow probe with a direct Future.State.SUCCESS check, which is the intended state query and does not throw.
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.708 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Member
|
Will fix the ParallelScheduler test leak in a separate PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SchedulerToExecutorService.invokeAny()checks each future with:But
Future.exceptionNow()is specified to throwIllegalStateExceptionwhen the task completed normally (there is no exception to return). So as soon as a task finishes successfully, this guard callsexceptionNow()on a successfully-completed future and throwsIllegalStateExceptioninstead of returning the result. BothinvokeAnyoverloads contain the same probe.Fix
Use the intended state query, which never throws:
Test
Adds
SchedulerToExecutorServiceTestcovering the success paths. The newinvokeAnyShouldReturnResultOfCompletedTaskandinvokeAnyWithSingleTasktests fail onmasterwithIllegalStateExceptionand pass with this fix.Note: the timed
invokeAny(tasks, timeout, unit)overload has a separate pre-existing issue in its time accounting (theFIXME-marked spin loop) that this PR intentionally does not touch; it only addresses theexceptionNow()misuse.