Skip to content

4x unit test lambdas18#8160

Merged
akarnokd merged 4 commits into
ReactiveX:4.xfrom
akarnokd:4xUnitTestLambdas18
Jun 22, 2026
Merged

4x unit test lambdas18#8160
akarnokd merged 4 commits into
ReactiveX:4.xfrom
akarnokd:4xUnitTestLambdas18

Conversation

@akarnokd

@akarnokd akarnokd commented Jun 22, 2026

Copy link
Copy Markdown
Member

Will go over the unit tests in ASCII order of the classpath and classes.

IntelliJ: Inspect -> RedundantCast, Inspect -> Anonymous type can be replaced by lambda
Search regexp: new\s+\w+(?:\s*<(?:[\s\w<>(\[\])?,.?]|\s*<[\s\w<>(\[\])?,.?]*>)*>)?\s*\([^)]*\)\s*\{

/* NFI */ = Not Functional Interface so break the regexp pattern

If you complain instead of proposing a PR about "why not convert to method references" you'll be banned.

Related: #8080

Also fixed the ParallelScheduler test leak, detected in #8159.

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.647 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/main/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorService.java: 4.455
src/test/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorServiceTest.java: 4.839

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.647 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/main/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorService.java: 4.455
src/test/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorServiceTest.java: 4.839

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.647 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/main/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorService.java: 4.455
src/test/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorServiceTest.java: 4.839

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.76%. Comparing base (bb5ea04) to head (19dfae5).
⚠️ Report is 1 commits behind head on 4.x.

Files with missing lines Patch % Lines
.../reactivex/rxjava4/subscribers/TestSubscriber.java 0.00% 5 Missing ⚠️
...a/io/reactivex/rxjava4/observers/TestObserver.java 80.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (40.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8160      +/-   ##
============================================
+ Coverage     98.75%   98.76%   +0.01%     
- Complexity     6934     6940       +6     
============================================
  Files           773      773              
  Lines         48984    48994      +10     
  Branches       6586     6586              
============================================
+ Hits          48372    48387      +15     
+ Misses          454      442      -12     
- Partials        158      165       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd akarnokd merged commit 1e4ffe7 into ReactiveX:4.x Jun 22, 2026
5 of 6 checks passed
@akarnokd akarnokd deleted the 4xUnitTestLambdas18 branch June 23, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant