Skip to content

Move TestHelper.race tests into @Isolated classes: batch 2 (#8075) - #8257

Merged
akarnokd merged 1 commit into
ReactiveX:4.xfrom
oaksprout:isolate-race-tests-observable-flatmap-mergewith
Aug 3, 2026
Merged

Move TestHelper.race tests into @Isolated classes: batch 2 (#8075)#8257
akarnokd merged 1 commit into
ReactiveX:4.xfrom
oaksprout:isolate-race-tests-observable-flatmap-mergewith

Conversation

@oaksprout

Copy link
Copy Markdown
Contributor

Continues the pattern from #8253 onto the Observable flatMap/mergeWith family, the direct counterpart to the Flowable batch already merged. Same shape: TestHelper.race( calls moved into new *IsolatedTest.java classes, @isolated annotation, originals otherwise untouched.

9 methods moved across 6 classes (smaller than batch 1's 15, since Observable has no backpressure protocol, so the request based race variants don't apply here).

Tests: all 12 touched classes, run twice, 0 failures / 0 errors both rounds. Full tree compileTestJava and checkstyleTest both clean. JDK 26.

179 to 173 files with the pattern remain.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.841 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

.github/workflows/gradle_branch.yml: 5.078
.github/workflows/gradle_pr.yml: 4.933
.github/workflows/gradle_preview_jdks.yml: 5.102
.github/workflows/gradle_release.yml: 5.206
.github/workflows/gradle_snapshot.yml: 5.057
.github/workflows/scorecard.yml: 4.765
src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapIsolatedTest.java: 4.677
src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapMaybeIsolatedTest.java: 4.802
src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapMaybeTest.java: 4.714
src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapSingleIsolatedTest.java: 4.897
src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapSingleTest.java: 4.728
src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapTest.java: 4.624
src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithCompletableIsolatedTest.java: 4.873
src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithCompletableTest.java: 4.712
src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithMaybeIsolatedTest.java: 4.892
src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithMaybeTest.java: 4.609
src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithSingleIsolatedTest.java: 4.882
src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithSingleTest.java: 4.592

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.56%. Comparing base (ddcbd7b) to head (ab1e8f6).
⚠️ Report is 3 commits behind head on 4.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8257      +/-   ##
============================================
- Coverage     98.63%   98.56%   -0.08%     
+ Complexity     7146     7141       -5     
============================================
  Files           824      824              
  Lines         50768    50768              
  Branches       6905     6905              
============================================
- Hits          50075    50037      -38     
- Misses          476      496      +20     
- Partials        217      235      +18     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd akarnokd added this to the 4.0 milestone Aug 3, 2026
@akarnokd akarnokd added the AI label Aug 3, 2026
@akarnokd
akarnokd merged commit f3c6705 into ReactiveX:4.x Aug 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants