refactor: restructure settings component layout and styles#475
Merged
deltork merged 1 commit intoNov 20, 2025
Merged
Conversation
|
Review changes with Changed Files
|
Contributor
|
Member
|
Wow, the regular git diff is spectacularly bad here! I've never seen SemanticDiff boast 99% shorter diff before, but there we go, this is the kind of PR for which SemanticDiff is useful. |
sergeleger
approved these changes
Nov 20, 2025
sergeleger
left a comment
sergeleger
left a comment
Collaborator
There was a problem hiding this comment.
Looks better to me! thanks Del.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Very minor tweak of the settings dialog
before
after
Fixes?
Feedback sought?
Yea or Nay on the tweak
Priority?
High
Tests added?
n/a
How to test?
Make a read along and click the settings icon on the read-along.
Confidence?
High
Version change?
n/a