fix: better messages when alignment fails#484
Merged
Conversation
|
Review changes with Changed Files
|
Contributor
|
sergeleger
approved these changes
Dec 11, 2025
Collaborator
sergeleger
left a comment
sergeleger
left a comment
There was a problem hiding this comment.
This works for me and the warning toasts for first and second failures are logical since the audio processing has not yet fully completed.
joanise
force-pushed
the
dev.ej/better-alignment-error-messages
branch
from
5e1d175 to
50a72f2
Compare
joanise
force-pushed
the
dev.ej/better-alignment-error-messages
branch
from
50a72f2 to
9ba87d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
When we get to the third alignment failure toast, the message was confusing and not helpful, so improve it.
When we get to the second alignment failure toast, it should be a warning only since we automatically try again.
Fixes?
The note quite intuitive messages we get on alignment failure.
Feedback sought?
Do you agree this is more intuitive?
Priority?
low
Tests added?
no
How to test?
enter this as text:
record a second or two of noise
then click on go to the next step
Confidence?
medium high
Version change?
no