Skip to content

Add rslidar_sdk#51

Merged
traversaro merged 4 commits into
RoboStack:mainfrom
diegoferigo-rai:diegoferigo/rslidar_sdk
Mar 2, 2026
Merged

Add rslidar_sdk#51
traversaro merged 4 commits into
RoboStack:mainfrom
diegoferigo-rai:diegoferigo/rslidar_sdk

Conversation

@diegoferigo-rai
Copy link
Copy Markdown
Contributor

https://github.com/RoboSense-LiDAR/rslidar_sdk

I have tested these changes by building locally on linux-64, and everything seems to be working fine.

I noticed that rslidar-msg is missing (it's in rosdep but not packaged in robostack-kilted). I noticed that vinca automatically picks it up and generates the recipe for it first.

Since this is my first contribution here, please let me know if anything else is needed or if I should adjust anything for the review process.

As a side note: even though vinca is currently somewhat light on documentation, the overall developer experience was pretty smooth. Well done on setting this up! :)

@diegoferigo
Copy link
Copy Markdown

Windows isn't working OOTB (classic). Since we don't use it internally and I don't have any local machine, it's a bit hard to justify the time to get it supported right now. I hope it's fine with upstream to merge these as Linux/macOS only for now.

@diegoferigo
Copy link
Copy Markdown

@Tobias-Fischer thanks for approving! Once this is merged, what's the next step? Does CI automatically push the new package to robostack as soon as it hits main, or is there a manual step? Or does it require waiting for the next full rebuild?

@Tobias-Fischer
Copy link
Copy Markdown
Contributor

@Tobias-Fischer thanks for approving! Once this is merged, what's the next step? Does CI automatically push the new package to robostack as soon as it hits main, or is there a manual step? Or does it require waiting for the next full rebuild?

Once merged it'll automatically build in CI :)

@Tobias-Fischer
Copy link
Copy Markdown
Contributor

@traversaro could you please take a look?

@traversaro
Copy link
Copy Markdown
Member

Ok for me, once the conflict is fixed we can merge!

@diegoferigo-rai
Copy link
Copy Markdown
Contributor Author

@traversaro merged main and resolved the conflicts. Good to go from my side once CI is green.

@traversaro traversaro merged commit f01ebb2 into RoboStack:main Mar 2, 2026
5 checks passed
@diegoferigo-rai diegoferigo-rai deleted the diegoferigo/rslidar_sdk branch March 8, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants