Add rslidar_sdk#51
Conversation
|
Windows isn't working OOTB (classic). Since we don't use it internally and I don't have any local machine, it's a bit hard to justify the time to get it supported right now. I hope it's fine with upstream to merge these as Linux/macOS only for now. |
|
@Tobias-Fischer thanks for approving! Once this is merged, what's the next step? Does CI automatically push the new package to robostack as soon as it hits |
Once merged it'll automatically build in CI :) |
|
@traversaro could you please take a look? |
|
Ok for me, once the conflict is fixed we can merge! |
|
@traversaro merged |
https://github.com/RoboSense-LiDAR/rslidar_sdk
I have tested these changes by building locally on
linux-64, and everything seems to be working fine.I noticed that
rslidar-msgis missing (it's inrosdepbut not packaged inrobostack-kilted). I noticed thatvincaautomatically picks it up and generates the recipe for it first.Since this is my first contribution here, please let me know if anything else is needed or if I should adjust anything for the review process.
As a side note: even though
vincais currently somewhat light on documentation, the overall developer experience was pretty smooth. Well done on setting this up! :)