Skip to content

Update Grid.js#115

Merged
rctoris merged 2 commits intoRobotWebTools:developfrom
rbonghi:patch-3
Jul 7, 2015
Merged

Update Grid.js#115
rctoris merged 2 commits intoRobotWebTools:developfrom
rbonghi:patch-3

Conversation

@rbonghi
Copy link
Contributor

@rbonghi rbonghi commented Jun 11, 2015

Now the grid use option in SI.
Fixed size

Now the grid use option in SI.
Fixed size
@T045T
Copy link
Contributor

T045T commented Jun 11, 2015

I'm not sure this is an improvement.

For example: What if size isn't a clean multiple of cellSize? Seems like you'd end up with a Grid that's not actually the size you specified in the options, wouldn't you?

@rbonghi
Copy link
Contributor Author

rbonghi commented Jun 12, 2015

Yes, I forgot this problem.

I suggest to change the name size in num_cell in according with same name in rviz application.

@rbonghi
Copy link
Contributor Author

rbonghi commented Jun 16, 2015

I have renamed size in num_cells. Now it's more readable.

rctoris added a commit that referenced this pull request Jul 7, 2015
@rctoris rctoris merged commit 321ffc4 into RobotWebTools:develop Jul 7, 2015
k-aguete pushed a commit to k-aguete/ros3djs that referenced this pull request Oct 21, 2022
…ion-default-value-issue

Fixed quaternion default value issue. Added Test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants