This repository was archived by the owner on Jun 7, 2020. It is now read-only.
Conversation
Did you missed me? 😛 Translated the remaining strings. 😁
This is probably the only approach I can find as `Favoritar/Desfavoritar` doesn't exist, at least in pt_PT 😛
Fixed some left typos 😄
[FIX][RCVC] Reintroduce "loading messages" indication
[I18N] Update Localizable.strings
[IMPROVEMENT] Show emojis and markdown in reply/quote popup
[IMPROVEMENT] Remove @ and add left & right spacing to mentions
[NEW] Copy message permalink
…feature/jitsi_integration
[I18N] Translate italian strings for video calls
…rom_the_app [CHORE] Remove the feature to block users locally from the app
[FIX] Read receipts missing on the list of messages
…etails_titleview.2502 [CHORE] Replace DM icon by bubble on titleView
[NEW] Support announcements
[CHORE] Remove unused code, resolve some SwiftLint warnings & suppress couple.
[CHORE] Remove @ from file attachments, autocomplete & quotes
…iption [FIX] View models deallocation & Subscription object mapping fixing on updates
…sword.2505 [FIX] Fixed color into forgot password button
[FIX] Fixed issue on connecting to a server & having an invalid server after all in some edge cases
…_details_channel [CHORE] Hide empty information from Channel Information
houndci-bot
reviewed
Feb 4, 2019
|
|
||
| XCTAssertEqual( | ||
| result.string, | ||
| "Hi \u{00a0}rafael.kellermann\u{00a0}, how are you doing? Is everyone \u{00a0}here\u{00a0} having a great day? How about you \u{00a0}filipe.alvarenga\u{00a0}? Wish you \u{00a0}all\u{00a0} a happy Christmas :) from \u{00a0}matheus.cardoso\u{00a0}", |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 259 characters (line_length)
| // swiftlint:disable function_body_length | ||
| func testMentionParsing() { | ||
| let string = "Hi @rafael.kellermann, how are you doing? " + | ||
| "Is everyone @here having a great day? How about you @filipe.alvarenga? Wish you @all a happy Christmas :) from @matheus.cardoso" |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 150 characters (line_length)
| ChannelInfoDescriptionCellData( | ||
| header = [ChannelInfoBasicCellData(title: "#\(subscription.name)")] | ||
|
|
||
|
|
There was a problem hiding this comment.
Vertical Whitespace Violation: Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
| self.reply(to: message) | ||
| }) | ||
|
|
||
| let permalink = UIAlertAction(title: localized("chat.message.actions.permalink"), style: .default, handler: { _ in |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 122 characters (line_length)
| let messageType: String? | ||
|
|
||
| init(id: String, roomId: String, text: String) { | ||
| init(id: String, roomId: String, text: String, messageType: String? = nil) { |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'id' (identifier_name)
| } | ||
|
|
||
| func sendMessage(text: String, subscription: UnmanagedSubscription, id: String = String.random(18), user: User? = AuthManager.currentUser(), realm: Realm? = Realm.current) { | ||
| func sendMessage(text: String, internalType: String? = nil, subscription: UnmanagedSubscription, id: String = String.random(18), user: User? = AuthManager.currentUser(), realm: Realm? = Realm.current) { |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'id' (identifier_name)
Line Length Violation: Line should be 120 characters or less: currently 206 characters (line_length)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios