Skip to content

chore: fetch all slashcommands on startup - #34167

Merged
kodiakhq[bot] merged 3 commits into
developfrom
chore/support-slashcommands-paginations
Dec 16, 2024
Merged

chore: fetch all slashcommands on startup#34167
kodiakhq[bot] merged 3 commits into
developfrom
chore/support-slashcommands-paginations

Conversation

@Gustrb

@Gustrb Gustrb commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Not all apps were being fetched since we would just get the default pagination size, so we would fetch only 50 apps, now we will search all the apps in order to have everything once the user is typing

Issue(s)

Steps to test or reproduce

Use a workspace with over 50 slashcommands, just check if all of them are available

Further comments

CONN-111

@changeset-bot

changeset-bot Bot commented Dec 12, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e0b35f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Dec 12, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.79%. Comparing base (7f22793) to head (e0b35f2).
⚠️ Report is 2511 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34167   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          511      511           
  Lines        22132    22132           
  Branches      5394     5394           
========================================
  Hits         16775    16775           
  Misses        4709     4709           
  Partials       648      648           
Flag Coverage Δ
unit 75.79% <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Dec 12, 2024

Copy link
Copy Markdown
Contributor
PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34167/
on branch gh-pages at 2024-12-16 11:53 UTC

@Gustrb
Gustrb marked this pull request as ready for review December 12, 2024 15:27
@Gustrb
Gustrb requested a review from a team as a code owner December 12, 2024 15:27
@Gustrb
Gustrb requested a review from tassoevan December 12, 2024 15:39
@dionisio-bot

dionisio-bot Bot commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@tassoevan tassoevan added this to the 7.2.0 milestone Dec 13, 2024
@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Dec 16, 2024
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 16, 2024
@kodiakhq
kodiakhq Bot merged commit b32c629 into develop Dec 16, 2024
@kodiakhq
kodiakhq Bot deleted the chore/support-slashcommands-paginations branch December 16, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants