MNT: final fixes before next release#1044
Merged
Merged
Conversation
Documentation, CHANGELOG and test polish ahead of the next release (v1.13.0), covering PRs merged since v1.12.0. CHANGELOG - Add missing entries: Individual Fins (#818), AIGFS/HRRR forecast models (#951), duplicate-controller fix (#949), Valkyrie flight example (#967). - Hygiene: de-duplicate #958/#966, move #974 to Fixed and #1041 to Removed only, drop the already-released #914 duplicate, and point the logging (#973) and ND-interp (#969) entries at their PRs. - Backfill #940/#941/#944 (shipped in v1.12.0 code but never logged) under the [v1.12.0] section. Docs - New exceptions reference page (rocketpy.exceptions) wired into the reference index; note UnstableRocketWarning in the rocket stability docs (#970). - tanks.rst: switch examples to radius_function= and add a deprecation note (#957). - forecast.rst: fix the HRRR example (missing code directive + stray sentence) (#951). - airbrakes.rst: document discrete vs continuous controllers (sampling_rate=None) (#946). - rocket_usage.rst: note that Parachute is now an abstract base; instantiate HemisphericalParachute (#958). Tests - New regression tests: 3D ND-interp NaN outside convex hull (#969), abstract Parachute cannot be instantiated (#958), Monte Carlo convergence stopping (#922), EnvironmentAnalysis surviving wind API (#1041), radial-burn grain geometry over time (#944), RingClusterMotor full flight (#924), discrete controller invoked once per node (#949), acceleration-based parachute trigger deploys (#911). - Backfill regression tests for ThrustCurve API timeouts (#940) and power_off/on_drag Function objects + _input attributes (#941). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1044 +/- ##
===========================================
+ Coverage 80.27% 81.52% +1.25%
===========================================
Files 104 118 +14
Lines 12769 15172 +2403
===========================================
+ Hits 10250 12369 +2119
- Misses 2519 2803 +284 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation,
CHANGELOG.mdand test polish ahead of the next release (v1.13.0), auditing every PR merged since v1.12.0. This "dá um tapa" on the changelog and docs and backfills missing tests. A separate PR will do the end-to-end bug hunt.CHANGELOG reconciliation
Added to
[Unreleased](were missing):Fin/TrapezoidalFin/EllipticalFin/FreeFormFin(ENH: Individual Fins #818)Hygiene fixes: de-duplicated #958/#966; moved #974 to Fixed and #1041 to Removed only; removed the already-released #914 duplicate; pointed the logging (#973) and ND-interp (#969) entries at their PRs instead of the issues.
Backfilled the
[v1.12.0]section with #940 (ThrustCurve timeouts), #941 (power_off/on_dragasFunction+_inputattrs) and #944 (radial-burn Jacobian) — these shipped in v1.12.0 code but were never logged.Documentation
rocketpy.exceptions) wired into the reference index; documentedUnstableRocketWarningin the rocket stability docs (ENH: Add custom exceptions and unstable rocket warning (#285) #970).tanks.rst: examples switched toradius_function=+ deprecation note (MNT: Renameradiustoradius_functioninCylindricalTankandSphericalTank#957).forecast.rst: fixed the HRRR example (missing code directive + stray copy-pasted sentence) (ENH: add AIGFS and HRRR Models to Forecast #951).airbrakes.rst: new "Discrete vs. Continuous Controllers" section explainingsampling_rate=None(ENH: Discrete and Continuous Controllers #946).rocket_usage.rst: note thatParachuteis now an abstract base; useHemisphericalParachute(MNT: refactor parachute implementation #958).Tests
New regression tests (all passing): 3D ND-interp NaN outside convex hull (#969), abstract
Parachuterejects instantiation (#958), Monte Carlo convergence stopping (#922),EnvironmentAnalysissurviving wind API (#1041), radial-burn grain geometry over time (#944),RingClusterMotorfull flight (#924), discrete controller invoked exactly once per node (#949), acceleration-based parachute trigger deploys (#911). Plus backfill tests for ThrustCurve timeouts (#940) and dragFunction/_inputattributes (#941).Verification
test_function.py,test_rocket.py,test_parachute.py,test_genericmotor.py,test_monte_carlo.py,test_ring_cluster_motor.py) pass with no regressions (--runslowincluded for the integration/env tests).exceptions.rstusesautomoduleon an importable module. The HRRR snippet was intentionally made a staticcode-block(notjupyter-execute) to avoid a network-dependent build.🤖 Generated with Claude Code