ENH: Auto-Detection of Pressure Conversion Factor#966
Merged
Conversation
MateusStano
added
Enhancement
MateusStano
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #966 +/- ##
===========================================
+ Coverage 80.27% 81.11% +0.84%
===========================================
Files 104 113 +9
Lines 12769 14582 +1813
===========================================
+ Hits 10250 11828 +1578
- Misses 2519 2754 +235 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
Member
There was a problem hiding this comment.
the CHANGELOG.md file must be updated...
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores expected pressure-unit handling for file-based atmospheric models by introducing auto-detection of the pressure conversion factor (to Pa) when Environment.set_atmospheric_model() is used with forecast/reanalysis/ensemble datasets.
Changes:
- Allow
pressure_conversion_factor=Noneand auto-detect the factor from model/dictionary shortcuts and/or NetCDF variableunits. - Add unit auto-detection in
get_pressure_levels_from_file()when the conversion factor isNone. - Emit a runtime warning if the resulting ground-level pressure is outside a sanity range, guiding users to override the conversion factor.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
rocketpy/environment/tools.py |
Auto-detect pressure unit conversion from the NetCDF level variable units attribute when no factor is provided. |
rocketpy/environment/environment.py |
Default pressure_conversion_factor to None, implement model/dictionary-based detection with metadata fallback, and warn on implausible ground pressure. |
Gui-FernandesBR
force-pushed
the
enh/auto-pressure-conversion-factor
branch
from
7d27c90 to
b463870
Compare
Gui-FernandesBR
pushed a commit
to khushalkottaru/RocketPy
that referenced
this pull request
Jun 19, 2026
Gui-FernandesBR
added a commit
that referenced
this pull request
Jul 4, 2026
* MNT: final fixes before next release Documentation, CHANGELOG and test polish ahead of the next release (v1.13.0), covering PRs merged since v1.12.0. CHANGELOG - Add missing entries: Individual Fins (#818), AIGFS/HRRR forecast models (#951), duplicate-controller fix (#949), Valkyrie flight example (#967). - Hygiene: de-duplicate #958/#966, move #974 to Fixed and #1041 to Removed only, drop the already-released #914 duplicate, and point the logging (#973) and ND-interp (#969) entries at their PRs. - Backfill #940/#941/#944 (shipped in v1.12.0 code but never logged) under the [v1.12.0] section. Docs - New exceptions reference page (rocketpy.exceptions) wired into the reference index; note UnstableRocketWarning in the rocket stability docs (#970). - tanks.rst: switch examples to radius_function= and add a deprecation note (#957). - forecast.rst: fix the HRRR example (missing code directive + stray sentence) (#951). - airbrakes.rst: document discrete vs continuous controllers (sampling_rate=None) (#946). - rocket_usage.rst: note that Parachute is now an abstract base; instantiate HemisphericalParachute (#958). Tests - New regression tests: 3D ND-interp NaN outside convex hull (#969), abstract Parachute cannot be instantiated (#958), Monte Carlo convergence stopping (#922), EnvironmentAnalysis surviving wind API (#1041), radial-burn grain geometry over time (#944), RingClusterMotor full flight (#924), discrete controller invoked once per node (#949), acceleration-based parachute trigger deploys (#911). - Backfill regression tests for ThrustCurve API timeouts (#940) and power_off/on_drag Function objects + _input attributes (#941). * make format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #955 a pressure unit conversion was added to the
set_atmospheric_model. This fixed the pressure units for the new "Forecast" models added in #943. However, currently the default pressure unit is "Pa" when it used to be "hPa", this broke the definition of atmospheric models defined by files (such as reanalysis usage). One example of this breaking can be found incamoes_flight_sim.ipynbThis PR adds the functionality to automatically set the pressure unit based on the File/Model type
Breaking change