Complete ESP32-C6 schematic and organize hardware layout - #1
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
There are KiCad project/library correctness and maintainability issues (footprint library alias mismatch, placeholder/duplicate library files, and contradictory contribution guidance) that should be resolved before merge.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds project-level documentation and contribution/issue workflow templates, plus checks in a self-contained KiCad hardware project/library set for the LIONv3 (ESP32‑C6) module.
Changes:
- Introduces dual-licensing documentation/assets (MIT for
software/, CERN-OHL-P-2.0 forhardware/) and expandsREADME.md. - Adds contribution guidelines and GitHub issue/PR templates to standardize collaboration.
- Adds/organizes KiCad project configuration and a local symbol/footprint library set for the hardware design.
File summaries
| File | Description |
|---|---|
| software/LICENSE | Adds MIT license text for software artifacts. |
| README.md | Expands project overview, repo structure, releases table, and dual-licensing section. |
| hardware/LIONv3/sym-lib-table | Adds local KiCad symbol library table entry. |
| hardware/LIONv3/LIONv3.kicad_pro | Adds KiCad project configuration (board/schematic settings). |
| hardware/LIONv3/LIONv3-Footprints/X2SON-4_L1.0-W1.0-P0.65-TL-EP.kicad_mod | Adds footprint to local KiCad footprint library. |
| hardware/LIONv3/LIONv3-Footprints/X2-DFN1006-2_L1.0-W0.6-P0.65-RD.kicad_mod | Adds footprint to local KiCad footprint library. |
| hardware/LIONv3/LIONv3-Footprints/WSON-6_L2.0-W2.0-P0.65-TL-EP.kicad_mod | Adds footprint to local KiCad footprint library. |
| hardware/LIONv3/LIONv3-Footprints/WIFIM-SMD_61P-L16.6-W13.2-P0.80-ESP32-C6-MINI-1-N4.kicad_mod | Adds ESP32‑C6‑MINI footprint to local library. |
| hardware/LIONv3/LIONv3-Footprints/WIFIM-SMD_22P-L26.0-W16.0-P1.27-TL.kicad_mod | Adds footprint to local KiCad footprint library. |
| hardware/LIONv3/LIONv3-Footprints/VQFN-10_L2.0-W2.0-P0.45-TL.kicad_mod | Adds footprint to local KiCad footprint library. |
| hardware/LIONv3/LIONv3-Footprints/USB-C-SMD_TYPE-C-16PIN-2MD-073.kicad_mod | Adds USB‑C receptacle footprint to local library. |
| hardware/LIONv3/LIONv3-Footprints/Untitled.kicad_mod | Adds a footprint file (currently appears to be an unrenamed placeholder). |
| hardware/LIONv3/LIONv3-Footprints/UDFN-4_L1.0-W1.0-P0.65-TL.kicad_mod | Adds footprint to local KiCad footprint library. |
| hardware/LIONv3/LIONv3-Footprints/SOT-563_L1.6-W1.2-P0.50-LS1.6-BR.kicad_mod | Adds footprint to local KiCad footprint library. |
| hardware/LIONv3/LIONv3-Footprints/SOIC-8_L5.3-W5.3-P1.27-LS8.0-BL.kicad_mod | Adds footprint to local KiCad footprint library. |
| hardware/LIONv3/LIONv3-Footprints/SOIC-8_L4.9-W3.9-P1.27-LS6.0-BL.kicad_mod | Adds footprint to local KiCad footprint library. |
| hardware/LIONv3/LIONv3-Footprints/R1206.kicad_mod | Adds resistor footprint to local KiCad footprint library. |
| hardware/LIONv3/LIONv3-Footprints/QFN-48_L7.0-W7.0-P0.50-BL-EP5.1.kicad_mod | Adds footprint to local KiCad footprint library. |
| hardware/LIONv3/LIONv3-Footprints/MSOP-10_L3.0-W3.0-P0.50-LS5.0-BL.kicad_mod | Adds footprint to local KiCad footprint library. |
| hardware/LIONv3/LIONv3-Footprints/LIONv3-Symbols.kicad_sym | Adds a symbol library file within the footprint library directory. |
| hardware/LIONv3/LIONv3-Footprints/LED0603-RD_RED.kicad_mod | Adds LED footprint variant to local library. |
| hardware/LIONv3/LIONv3-Footprints/LED0603-RD_GREEN.kicad_mod | Adds LED footprint variant to local library. |
| hardware/LIONv3/LIONv3-Footprints/LED0603-RD_BLUE.kicad_mod | Adds LED footprint variant to local library. |
| hardware/LIONv3/LIONv3-Footprints/KEY-SMD_L3.9-W3.0-LS5.0.kicad_mod | Adds tact-switch footprint to local library. |
| hardware/LIONv3/LIONv3-Footprints/CRYSTAL-SMD_L5.0-W3.2.kicad_mod | Adds crystal footprint to local library. |
| hardware/LIONv3/LIONv3-Footprints/CONN-SMD_4P-P1.25_53261-0471.kicad_mod | Adds connector footprint to local library. |
| hardware/LIONv3/LIONv3-Footprints/CONN-SMD_2P-P1.25-HC-1.25-2PWT.kicad_mod | Adds connector footprint to local library. |
| hardware/LIONv3/fp-lib-table | Adds local KiCad footprint library table entry. |
| hardware/LICENSE | Adds CERN-OHL-P-2.0 license text for hardware assets. |
| CONTRIBUTING.md | Adds contribution, verification, and Git workflow guidelines. |
| CHANGELOG.md | Adds changelog placeholder file. |
| .gitignore | Ignores **/jlcpcb directories. |
| .github/PULL_REQUEST_TEMPLATE.md | Adds a PR template for consistent submissions. |
| .github/ISSUE_TEMPLATE/inquiry.md | Adds inquiry issue template. |
| .github/ISSUE_TEMPLATE/feature_request.md | Adds feature request issue template. |
| .github/ISSUE_TEMPLATE/bug_report.md | Adds bug report issue template. |
Review details
- Files reviewed: 35/65 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
+4
| (fp_lib_table | ||
| (version 7) | ||
| (lib (name "LIONv3-Footprints") (type "KiCad") (uri "${KIPRJMOD}/LIONv3-Footprints") (options "") (descr "")) | ||
| ) |
Comment on lines
+1
to
+5
| (footprint "Untitled" | ||
| (version 20260206) | ||
| (generator "pcbnew") | ||
| (generator_version "10.0") | ||
| (layer "F.Cu") |
| @@ -0,0 +1 @@ | |||
|
|
|||
|
|
||
| * **Toolchain:** Use KiCad for all schematic and PCB layout design. | ||
| * **Rule Checks:** Before committing any PCB changes, you **must** run and clear the Electrical Rule Check (ERC) and Design Rule Check (DRC). Pull Requests with ERC/DRC violations will be rejected. | ||
| * **Generated Files:** Do not commit manufacturing outputs (Gerbers, NC Drill, BOM) or 3D STEP files during regular development. These are generated exclusively by repository administrators during tagged release cycles to prevent synchronization issues. |
Comment on lines
+1
to
+5
| (kicad_symbol_lib (version 20210201) (generator TousstNicolas/JLC2KiCad_lib) | ||
| (symbol "HC-1_25-2PWT" (in_bom yes) (on_board yes) | ||
| (property "Reference" "U" (id 0) (at 0 1.27 0) | ||
| (effects (font (size 1.27 1.27))) | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive improvements to the project's documentation, contribution workflow, and repository structure. The main changes include the addition of detailed contribution guidelines, new issue and pull request templates, enhanced project documentation in the
README.md, and the inclusion of hardware licensing information. Additionally, a new hardware footprint file has been added.Documentation and Contribution Process Improvements:
CONTRIBUTING.mdoutlining licensing, coding standards, hardware design practices, verification requirements, and the project's Git workflow..github/ISSUE_TEMPLATE/, as well as a pull request template, to standardize and improve communication and traceability.Repository and Project Documentation:
README.mdto include a project overview, repository structure, release table, contribution instructions, and detailed dual-licensing information for hardware and software.Licensing and Hardware Assets:
hardware/LICENSEto clarify hardware usage and distribution rights.Other:
CHANGELOG.mdfile as a placeholder for future release notes.