Skip to content

Conversation

@marcorosa
Copy link
Member

Updated

  • update models with reference of official sap note from September (add mistral-medium)

Changed

  • do not require mandatory tracing

Fixed

  • Fix gptfuzz call

Chore

  • Add some optimization strategies to Dockerfile to try to respect the memory limit imposed by gha

dependabot bot and others added 29 commits September 29, 2025 13:34
Bumps [sentence-transformers](https://github.com/UKPLab/sentence-transformers) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/UKPLab/sentence-transformers/releases)
- [Commits](huggingface/sentence-transformers@v5.1.0...v5.1.1)

---
updated-dependencies:
- dependency-name: sentence-transformers
  dependency-version: 5.1.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pandas](https://github.com/pandas-dev/pandas) from 2.3.2 to 2.3.3.
- [Release notes](https://github.com/pandas-dev/pandas/releases)
- [Commits](pandas-dev/pandas@v2.3.2...v2.3.3)

---
updated-dependencies:
- dependency-name: pandas
  dependency-version: 2.3.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sentence-transformers](https://github.com/UKPLab/sentence-transformers) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/UKPLab/sentence-transformers/releases)
- [Commits](huggingface/sentence-transformers@v5.1.0...v5.1.1)

---
updated-dependencies:
- dependency-name: sentence-transformers
  dependency-version: 5.1.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [langchain-community](https://github.com/langchain-ai/langchain) from 0.3.29 to 0.3.30.
- [Release notes](https://github.com/langchain-ai/langchain/releases)
- [Commits](langchain-ai/langchain@langchain-core==0.3.29...langchain-core==0.3.30)

---
updated-dependencies:
- dependency-name: langchain-community
  dependency-version: 0.3.30
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…langchain-community-0.3.30

Bump langchain-community from 0.3.29 to 0.3.30 in /backend-agent
…sentence-transformers-5.1.1

Bump sentence-transformers from 5.1.0 to 5.1.1 in /backend-agent
…pandas-2.3.3

Bump pandas from 2.3.2 to 2.3.3 in /backend-agent
…/sentence-transformers-5.1.1

Bump sentence-transformers from 5.1.0 to 5.1.1 in /backend-agent
Add many optimization strategies to try not to exceed the space
limitations from GitHub Actions.
Update models with note 26-09-25
[chore] Optimize k8s steps in GHA
Bumps [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) from 6 to 7.
- [Release notes](https://github.com/astral-sh/setup-uv/releases)
- [Commits](astral-sh/setup-uv@v6...v7)

---
updated-dependencies:
- dependency-name: astral-sh/setup-uv
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [langchain-core](https://github.com/langchain-ai/langchain) from 0.3.76 to 0.3.79.
- [Release notes](https://github.com/langchain-ai/langchain/releases)
- [Commits](langchain-ai/langchain@langchain-core==0.3.76...langchain-core==0.3.79)

---
updated-dependencies:
- dependency-name: langchain-core
  dependency-version: 0.3.79
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [langchain-community](https://github.com/langchain-ai/langchain) from 0.3.30 to 0.3.31.
- [Release notes](https://github.com/langchain-ai/langchain/releases)
- [Commits](langchain-ai/langchain@langchain-core==0.3.30...langchain-core==0.3.31)

---
updated-dependencies:
- dependency-name: langchain-community
  dependency-version: 0.3.31
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sap-ai-sdk-gen[all]](https://www.sap.com/) from 5.6.3 to 5.7.5.

---
updated-dependencies:
- dependency-name: sap-ai-sdk-gen[all]
  dependency-version: 5.7.5
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps the js-dependencies group with 22 updates in the /frontend directory:

| Package | From | To |
| --- | --- | --- |
| [@angular/animations](https://github.com/angular/angular/tree/HEAD/packages/animations) | `20.3.2` | `20.3.4` |
| [@angular/cdk](https://github.com/angular/components) | `20.2.5` | `20.2.8` |
| [@angular/common](https://github.com/angular/angular/tree/HEAD/packages/common) | `20.3.2` | `20.3.4` |
| [@angular/compiler](https://github.com/angular/angular/tree/HEAD/packages/compiler) | `20.3.2` | `20.3.4` |
| [@angular/core](https://github.com/angular/angular/tree/HEAD/packages/core) | `20.3.2` | `20.3.4` |
| [@angular/forms](https://github.com/angular/angular/tree/HEAD/packages/forms) | `20.3.2` | `20.3.4` |
| [@angular/material](https://github.com/angular/components) | `20.2.5` | `20.2.8` |
| [@angular/platform-browser](https://github.com/angular/angular/tree/HEAD/packages/platform-browser) | `20.3.2` | `20.3.4` |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular/tree/HEAD/packages/platform-browser-dynamic) | `20.3.2` | `20.3.4` |
| [@angular/router](https://github.com/angular/angular/tree/HEAD/packages/router) | `20.3.2` | `20.3.4` |
| [ng-apexcharts](https://github.com/apexcharts/ng-apexcharts) | `2.0.1` | `2.0.3` |
| [@angular-devkit/build-angular](https://github.com/angular/angular-cli) | `20.3.3` | `20.3.5` |
| [@angular-eslint/builder](https://github.com/angular-eslint/angular-eslint/tree/HEAD/packages/builder) | `20.3.0` | `20.4.0` |
| [@angular-eslint/eslint-plugin](https://github.com/angular-eslint/angular-eslint/tree/HEAD/packages/eslint-plugin) | `20.3.0` | `20.4.0` |
| [@angular-eslint/eslint-plugin-template](https://github.com/angular-eslint/angular-eslint/tree/HEAD/packages/eslint-plugin-template) | `20.3.0` | `20.4.0` |
| [@angular-eslint/schematics](https://github.com/angular-eslint/angular-eslint/tree/HEAD/packages/schematics) | `20.3.0` | `20.4.0` |
| [@angular/cli](https://github.com/angular/angular-cli) | `20.3.3` | `20.3.5` |
| [@angular/compiler-cli](https://github.com/angular/angular/tree/HEAD/packages/compiler-cli) | `20.3.2` | `20.3.4` |
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `8.45.0` | `8.46.0` |
| [eslint](https://github.com/eslint/eslint) | `9.36.0` | `9.37.0` |
| [jasmine-core](https://github.com/jasmine/jasmine) | `5.11.0` | `5.12.0` |
| [typescript](https://github.com/microsoft/TypeScript) | `5.9.2` | `5.9.3` |



Updates `@angular/animations` from 20.3.2 to 20.3.4
- [Release notes](https://github.com/angular/angular/releases)
- [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md)
- [Commits](https://github.com/angular/angular/commits/20.3.4/packages/animations)

Updates `@angular/cdk` from 20.2.5 to 20.2.8
- [Release notes](https://github.com/angular/components/releases)
- [Changelog](https://github.com/angular/components/blob/main/CHANGELOG.md)
- [Commits](angular/components@20.2.5...20.2.8)

Updates `@angular/common` from 20.3.2 to 20.3.4
- [Release notes](https://github.com/angular/angular/releases)
- [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md)
- [Commits](https://github.com/angular/angular/commits/20.3.4/packages/common)

Updates `@angular/compiler` from 20.3.2 to 20.3.4
- [Release notes](https://github.com/angular/angular/releases)
- [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md)
- [Commits](https://github.com/angular/angular/commits/20.3.4/packages/compiler)

Updates `@angular/core` from 20.3.2 to 20.3.4
- [Release notes](https://github.com/angular/angular/releases)
- [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md)
- [Commits](https://github.com/angular/angular/commits/20.3.4/packages/core)

Updates `@angular/forms` from 20.3.2 to 20.3.4
- [Release notes](https://github.com/angular/angular/releases)
- [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md)
- [Commits](https://github.com/angular/angular/commits/20.3.4/packages/forms)

Updates `@angular/material` from 20.2.5 to 20.2.8
- [Release notes](https://github.com/angular/components/releases)
- [Changelog](https://github.com/angular/components/blob/main/CHANGELOG.md)
- [Commits](angular/components@20.2.5...20.2.8)

Updates `@angular/platform-browser` from 20.3.2 to 20.3.4
- [Release notes](https://github.com/angular/angular/releases)
- [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md)
- [Commits](https://github.com/angular/angular/commits/20.3.4/packages/platform-browser)

Updates `@angular/platform-browser-dynamic` from 20.3.2 to 20.3.4
- [Release notes](https://github.com/angular/angular/releases)
- [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md)
- [Commits](https://github.com/angular/angular/commits/20.3.4/packages/platform-browser-dynamic)

Updates `@angular/router` from 20.3.2 to 20.3.4
- [Release notes](https://github.com/angular/angular/releases)
- [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md)
- [Commits](https://github.com/angular/angular/commits/20.3.4/packages/router)

Updates `ng-apexcharts` from 2.0.1 to 2.0.3
- [Release notes](https://github.com/apexcharts/ng-apexcharts/releases)
- [Changelog](https://github.com/apexcharts/ng-apexcharts/blob/master/CHANGELOG.md)
- [Commits](apexcharts/ng-apexcharts@v2.0.1...v2.0.3)

Updates `@angular-devkit/build-angular` from 20.3.3 to 20.3.5
- [Release notes](https://github.com/angular/angular-cli/releases)
- [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md)
- [Commits](angular/angular-cli@20.3.3...20.3.5)

Updates `@angular-eslint/builder` from 20.3.0 to 20.4.0
- [Release notes](https://github.com/angular-eslint/angular-eslint/releases)
- [Changelog](https://github.com/angular-eslint/angular-eslint/blob/main/packages/builder/CHANGELOG.md)
- [Commits](https://github.com/angular-eslint/angular-eslint/commits/v20.4.0/packages/builder)

Updates `@angular-eslint/eslint-plugin` from 20.3.0 to 20.4.0
- [Release notes](https://github.com/angular-eslint/angular-eslint/releases)
- [Changelog](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/angular-eslint/angular-eslint/commits/v20.4.0/packages/eslint-plugin)

Updates `@angular-eslint/eslint-plugin-template` from 20.3.0 to 20.4.0
- [Release notes](https://github.com/angular-eslint/angular-eslint/releases)
- [Changelog](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/CHANGELOG.md)
- [Commits](https://github.com/angular-eslint/angular-eslint/commits/v20.4.0/packages/eslint-plugin-template)

Updates `@angular-eslint/schematics` from 20.3.0 to 20.4.0
- [Release notes](https://github.com/angular-eslint/angular-eslint/releases)
- [Changelog](https://github.com/angular-eslint/angular-eslint/blob/main/packages/schematics/CHANGELOG.md)
- [Commits](https://github.com/angular-eslint/angular-eslint/commits/v20.4.0/packages/schematics)

Updates `@angular-eslint/template-parser` from 20.3.0 to 20.4.0
- [Release notes](https://github.com/angular-eslint/angular-eslint/releases)
- [Changelog](https://github.com/angular-eslint/angular-eslint/blob/main/packages/template-parser/CHANGELOG.md)
- [Commits](https://github.com/angular-eslint/angular-eslint/commits/v20.4.0/packages/template-parser)

Updates `@angular/cli` from 20.3.3 to 20.3.5
- [Release notes](https://github.com/angular/angular-cli/releases)
- [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md)
- [Commits](angular/angular-cli@20.3.3...20.3.5)

Updates `@angular/compiler-cli` from 20.3.2 to 20.3.4
- [Release notes](https://github.com/angular/angular/releases)
- [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md)
- [Commits](https://github.com/angular/angular/commits/20.3.4/packages/compiler-cli)

Updates `@typescript-eslint/eslint-plugin` from 8.45.0 to 8.46.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.46.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 8.45.0 to 8.46.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.46.0/packages/parser)

Updates `eslint` from 9.36.0 to 9.37.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v9.36.0...v9.37.0)

Updates `jasmine-core` from 5.11.0 to 5.12.0
- [Release notes](https://github.com/jasmine/jasmine/releases)
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md)
- [Commits](jasmine/jasmine@v5.11.0...v5.12.0)

Updates `typescript` from 5.9.2 to 5.9.3
- [Release notes](https://github.com/microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release-publish.yml)
- [Commits](microsoft/TypeScript@v5.9.2...v5.9.3)

---
updated-dependencies:
- dependency-name: "@angular/animations"
  dependency-version: 20.3.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
- dependency-name: "@angular/cdk"
  dependency-version: 20.2.8
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
- dependency-name: "@angular/common"
  dependency-version: 20.3.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
- dependency-name: "@angular/compiler"
  dependency-version: 20.3.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
- dependency-name: "@angular/core"
  dependency-version: 20.3.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
- dependency-name: "@angular/forms"
  dependency-version: 20.3.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
- dependency-name: "@angular/material"
  dependency-version: 20.2.8
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
- dependency-name: "@angular/platform-browser"
  dependency-version: 20.3.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
- dependency-name: "@angular/platform-browser-dynamic"
  dependency-version: 20.3.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
- dependency-name: "@angular/router"
  dependency-version: 20.3.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
- dependency-name: ng-apexcharts
  dependency-version: 2.0.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
- dependency-name: "@angular-devkit/build-angular"
  dependency-version: 20.3.5
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
- dependency-name: "@angular-eslint/builder"
  dependency-version: 20.4.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: js-dependencies
- dependency-name: "@angular-eslint/eslint-plugin"
  dependency-version: 20.4.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: js-dependencies
- dependency-name: "@angular-eslint/eslint-plugin-template"
  dependency-version: 20.4.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: js-dependencies
- dependency-name: "@angular-eslint/schematics"
  dependency-version: 20.4.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: js-dependencies
- dependency-name: "@angular-eslint/template-parser"
  dependency-version: 20.4.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: js-dependencies
- dependency-name: "@angular/cli"
  dependency-version: 20.3.5
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
- dependency-name: "@angular/compiler-cli"
  dependency-version: 20.3.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-version: 8.46.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: js-dependencies
- dependency-name: "@typescript-eslint/parser"
  dependency-version: 8.46.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: js-dependencies
- dependency-name: eslint
  dependency-version: 9.37.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: js-dependencies
- dependency-name: jasmine-core
  dependency-version: 5.12.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: js-dependencies
- dependency-name: typescript
  dependency-version: 5.9.3
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: js-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
…langchain-core-0.3.79

Bump langchain-core from 0.3.76 to 0.3.79 in /backend-agent
…sap-ai-sdk-gen-all--5.7.5

Bump sap-ai-sdk-gen[all] from 5.6.3 to 5.7.5 in /backend-agent
…elop/js-dependencies-da0256529f

Bump the js-dependencies group across 1 directory with 24 updates
…langchain-community-0.3.31

Bump langchain-community from 0.3.30 to 0.3.31 in /backend-agent
Bumps [tensorflow](https://github.com/tensorflow/tensorflow) from 2.19.1 to 2.20.0.
- [Release notes](https://github.com/tensorflow/tensorflow/releases)
- [Changelog](https://github.com/tensorflow/tensorflow/blob/master/RELEASE.md)
- [Commits](tensorflow/tensorflow@v2.19.1...v2.20.0)

---
updated-dependencies:
- dependency-name: tensorflow
  dependency-version: 2.20.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…tensorflow-2.20.0

Bump tensorflow from 2.19.1 to 2.20.0 in /backend-agent
…tral-sh/setup-uv-7

Bump astral-sh/setup-uv from 6 to 7
Cache pruning was disabled due to a known bug on the uv's github action.
As they claim fixing it in their v7 release, we restore it.
@marcorosa marcorosa requested a review from a team as a code owner October 17, 2025 10:25
@github-actions
Copy link
Contributor

The changes encompass various improvements, optimizations, and updates across backend and frontend components, as well as CI/CD workflows. Key updates include version bumps of dependencies, enhanced Dockerfile optimizations, workflow upgrades for better resource management, additions of new model configurations, and adjustments to tracing logic in status.py. Additionally, there are package updates in package.json for Angular and TypeScript dependencies, allowing for more stable and secure frontend development.

Walkthrough

  • Chore: Upgraded setup-uv action from v6 to v7 for optimization of CI/CD pipeline with improved cache handling.
  • New Feature: Added setup for kubelogin in the GitHub Actions workflows to facilitate Kubernetes login operations.
  • Refactor: Enhanced Dockerfile with aggressive cleanup and optimization techniques to reduce image size and improve build speed.
  • New Feature: Updated configurations to include new models like gp-4o-mini and mistralai--mistral-medium-instruct.
  • Chore: Updated backend Python dependencies for efficiency and security; version bump to 0.6.1.
  • Style: Conditional logic added to status.py to ensure a clean trace handling.
  • Chore: Upgraded Angular and TypeScript dependencies in package.json to maintain alignment with newer versions, enhancing stability.

Model: gpt-4o | Prompt Tokens: 3151 | Completion Tokens: 273

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a collaborative code review enhanced with AI insights. These suggestions are recommendations to consider rather than definitive requirements, so please apply what feels most valuable for your project. You remain the expert decision-maker—AI simply provides additional perspective to support your development process.


Always critique what AI says. Do not let AI replace YOUR I.
Model: anthropic--claude-4-sonnet | Prompt Tokens: 5408 | Completion Tokens: 1112

Comment on lines -34 to +38
uses: astral-sh/setup-uv@v6
uses: astral-sh/setup-uv@v7
with:
version: "latest"
enable-cache: true
prune-cache: false
prune-cache: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good upgrade to setup-uv@v7 and enabling cache pruning. Consider pinning to a specific version instead of using 'latest' for better reproducibility:

uses: astral-sh/setup-uv@v7
with:
  version: "0.5.4"  # or specific version
  enable-cache: true
  prune-cache: true

Comment on lines +220 to 229
- name: Set up kubelogin
uses: azure/use-kubelogin@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
kubelogin-version: 'latest'

- name: Configure kubectl for SAP BTP Kyma
run: |
mkdir -p ~/.kube
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kubelogin setup step is duplicated across multiple jobs. Consider extracting this into a reusable composite action to reduce duplication:

# .github/actions/setup-kubelogin/action.yml
name: 'Setup kubelogin'
description: 'Sets up kubelogin for Kubernetes authentication'
runs:
  using: 'composite'
  steps:
    - name: Set up kubelogin
      uses: azure/use-kubelogin@v1
      env:
        GITHUB_TOKEN: ${{ github.token }}
      with:
        kubelogin-version: 'latest'

Comment on lines 27 to +58
RUN . ~/.cargo/env && \
uv sync --frozen --no-dev --no-cache && \
# Clean up any temporary files to reduce layer size
rm -rf /root/.cache/uv /tmp/* /var/tmp/* && \
# Remove Rust toolchain after build to reduce image size
rustup self uninstall -y
# Install dependencies with bytecode compilation for better performance
uv sync --frozen --no-dev --no-cache --compile-bytecode && \
# Immediate cleanup of build artifacts during installation
find /app/.venv -type d -name "__pycache__" -exec rm -rf {} + 2>/dev/null || true && \
find /app/.venv -name "*.pyc" -delete 2>/dev/null || true && \
find /app/.venv -name "*.pyo" -delete 2>/dev/null || true && \
# Remove test files and documentation from packages (keeping runtime libs)
find /app/.venv -type d -name "tests" -exec rm -rf {} + 2>/dev/null || true && \
find /app/.venv -type d -name "test" -exec rm -rf {} + 2>/dev/null || true && \
find /app/.venv -type d -name "docs" -exec rm -rf {} + 2>/dev/null || true && \
# Strip debug symbols from shared libraries to reduce size
find /app/.venv -name "*.so" -exec strip {} + 2>/dev/null || true && \
# Aggressive cache and temporary file cleanup
rm -rf /root/.cache/uv \
/root/.cache/pip \
/root/.cache/* \
/tmp/* \
/var/tmp/* \
/root/.cargo/registry \
/root/.cargo/git \
/app/.venv/share \
&& \
# Remove Rust toolchain completely after build
rustup self uninstall -y && \
# Final build tools cleanup to free space
apt-get autoremove -y build-essential git curl pkg-config && \
apt-get autoclean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dockerfile improvements look good with aggressive cleanup. However, the cleanup commands could be simplified and made more robust:

# Combine cleanup operations and use proper error handling
RUN . ~/.cargo/env && \
    uv sync --frozen --no-dev --no-cache --compile-bytecode && \
    # Single comprehensive cleanup
    find /app/.venv \( -name "__pycache__" -o -name "*.pyc" -o -name "*.pyo" \) -delete && \
    find /app/.venv -type d \( -name "tests" -o -name "test" -o -name "docs" \) -exec rm -rf {} + && \
    find /app/.venv -name "*.so" -exec strip --strip-debug {} + && \
    rm -rf /root/.cache /tmp/* /var/tmp/* /root/.cargo/registry /root/.cargo/git /app/.venv/share && \
    rustup self uninstall -y && \
    apt-get autoremove -y build-essential git curl pkg-config && \
    apt-get autoclean

Comment on lines +181 to +183
# Only trace if there's an active trace context
if hasattr(self, 'trace') and self.trace:
self.trace['llm_messages'].append(message)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good defensive programming with the trace check. Consider using a more explicit approach with a proper initialization:

def __init__(self):
    self.trace = {'llm_messages': []}  # Initialize properly
    
def log_llm_message(self, prompt: str, response):
    message = {
        'prompt': prompt,
        'response': response.to_dict()
    }
    # More explicit check
    if self.trace and 'llm_messages' in self.trace:
        self.trace['llm_messages'].append(message)

Comment on lines -15 to 19
dependencies = [
'sap-ai-sdk-gen[all]==5.6.3',
'sap-ai-sdk-gen[all]==5.7.5',
'python-dotenv==1.1.1',
'faiss-cpu==1.12.0',
'Flask==3.1.2',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency updates look good. Consider using version ranges for better compatibility and easier maintenance:

dependencies = [
    'sap-ai-sdk-gen[all]>=5.7.5,<6.0.0',
    'pandas>=2.3.3,<3.0.0',
    'sentence-transformers>=5.1.1,<6.0.0',
    'tensorflow>=2.20.0,<3.0.0',
    # ... other dependencies
]

@marcorosa marcorosa merged commit 3f668cb into main Oct 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant