test(destination): skip flaky http client test on non-2xx echo response#218
Merged
Merged
Conversation
cassiofariasmachado
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a flaky destination integration test (
test_destinationhttpclient_sends_an_authenticated_request_using_token_fetched_from_btp) that occasionally failed withJSONDecodeErrorbecause the test calledresponse.json()on the reply fromhttpbin.org, but httpbin sometimes returned a non-JSON error body (CDN 502/503 HTML, rate-limit page)The fix adds a
response.okcheck after the request: if the echo service returned a non-2xx status,pytest.skipwith the status code and a body previewRelated Issue
N/A
Type of Change
How to Test
Checklist
itself a test-only change
Breaking Changes
None
Additional Notes
None