Skip to content

test(destination): skip flaky http client test on non-2xx echo response #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jplbrun merged 1 commit into from
Jul 8, 2026
+8 −3
Merged

test(destination): skip flaky http client test on non-2xx echo response #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tests/destination/integration/test_destination_bdd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1615,10 +1615,15 @@ def send_get_request(context, path):
import requests
try:
context.http_response = context.http_client.request("GET", path)
except requests.exceptions.ConnectionError as e:
except (requests.exceptions.ConnectionError, requests.exceptions.Timeout) as e:
pytest.skip(f"External endpoint unreachable — skipping: {e}")
except requests.exceptions.Timeout as e:
pytest.skip(f"External endpoint timed out — skipping: {e}")

# skip if the echo service itself returned an error
if not context.http_response.ok:
pytest.skip(
f"External endpoint returned {context.http_response.status_code}: "
f"{context.http_response.text[:200]}"
)


@then("the response contains an Authorization header")
Expand Down
Loading