Update DNN ROI fcls for validation production, add option of run only DNN ROI

[wjdanswjddl]

Description

This PR updates and refactors fcls for running DNN-base ROI finding.
Previously, the JobConfigurations/standard fcls had commented lines that could be uncommented to enable DNN ROI. With this PR, all relevant fcls are stored in JobConfigurations/dnnroi and JobConfigurations/standard fcls run only the traditional workflow.
For the complete transition to DNN ROI for the upcoming fall production, the JobConfigurations/dnnroi/<standard_fcl_name>_dnnroi.fcl should replace the JobConfigurations/dnnroi/<standard_fcl_name>.fcl files.

Summary of changes in workflow:

• Updates on jsonnets and addition of fcls to run only DNN ROI finding
• structs:use_dnnroi knob to switch between running only traditional ROI and running traditional+DNN ROI in parallel is replaced with params:roi knob to choose between trad, dnn, both options.
• for each option, dedicated SP tables are configured in wcsimsp_sbnd.fcl and wcsp_data_sbnd.fcl files, instead of overwriting each configuration from detsim/reco fcls

new fcls relevant for DNN ROI validation production:

• MC:
  • standard_detsim_sbnd_bothrois.fcl: runs both ROIs during detsim-simtpc2d
  • standard_reco1_sbnd_dnnroi.fcl: runs Reco1 on simtpc2d:dnnsp Wire product
• Data:
  • reco1_data_bothrois.fcl: runs both ROIs during reco1-sptpc2d, run downstream reco1 on sptpc2d:gauss
  • scrub_gaushit_data.fcl: scrubs gaushit from the output of the above fcl
  • reco1_postscrub_data_dnnroi.fcl: run downstream reco1 again on the output of the above fcl, this time on sptpc2d:dnnsp

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

• Added at least 1 label from available labels.
• Assigned at least 1 reviewer under Reviewers,
• Assigned all contributers including yourself under Assignees
• Linked any relevant issues under Developement
• Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
• Does this affect the standard workflow?
• Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

[linyan-w]

Thank you for getting this together!
I suggest to split this PR into 2, PR#1 for validation 0 (August DNN ROI) & validation I (workshop sample), PR#2 for running only DNN ROI in validation II and production. PR#2 will include standard_detsim_sbnd_dnnroi.fcl and reco1_nosp_data_dnnroi.fcl. PR#1 will include everything else. We will first merge PR#1. After validation I we clean up and merge PR#2.

[nathanielerowe]

trigger build ci_ref=v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbncode@v10_06_00_03 SBNSoftware/sbnalg@v10_06_00_03 SBNSoftware/sbnobj@v10_01_01 SBNSoftware/sbnanaobj@v10_00_05 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_32_00

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[nathanielerowe]

trigger build ci_ref=v10_06_01 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbndcode@v10_06_01 SBNSoftware/sbncode@v10_06_00_01 SBNSoftware/sbnanaobj@v10_00_04 SBNSoftware/sbnobj@v10_01_00 SBNSoftware/sbnalg@v10_06_00_01

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[nathanielerowe]

Approved

[linyan-w]

Typo?

[nathanielerowe]

Yeah... Looks like it. Probably my fault. I can patch this in the release later this week. Is that a reasonable time scale for you?

[linyan-w]

Yep, thanks!