Conversation
|
Ideally I'd think we'd want each update to have them working, but all things considered its probably fine. I'm more curious why two of them were cancelled. |
3c119bb to
3fc2c0a
Compare
I think they're a part of one pipeline so if one fails the others are cancelled. I'm not sure if this is a good idea but could potentially save a lot of pipeline time (not any limits but if you submit multiple times they'll queue and take much longer). Let's say we forgot to put a variable in the example config that these run on, all pipelines would fail and it wouldn't be worth it to run the others. But, let's say it's an OS specific error, we'd have to fix one before moving onto the other...Not sure what's ideal here. |
The RL pipeline is not working properly with the new refactor including: - Input/Output results - Config files
Refactor/rl cli
Refactor/sim-core
📝 Description
This PR refactors the module responsible for input file generation. The logic from
setup_helpers.pyhas been moved to a more semantically appropriate location within the simulation package atfusion/sim/input_setup.py.This change improves the project's organization by grouping simulation-specific logic together. The PR also includes linting fixes for the
fusionpackage and updates the top-level tests to align with the new file structure.Fixes: # (issue number) ---
🧐 Type of Change
💥 Impact of Breaking Change
This is a minor breaking change due to the file relocation. Any internal modules that were importing directly from the old
setup_helpers.pywill be broken. This PR resolves the immediate impact on the top-level tests, but other areas could be affected. Any dependencies must be updated to import from the new path (fusion.sim.input_setup).🧪 How Has This Been Tested?
The refactoring has been verified with the following steps:
fusionpackage to ensure code style and quality are maintained.Test Configuration:
📸 Screenshots / Screen Recordings
✅ Final Checklist