Fix: increase vfido touch delay to avoid IPA auth timeout#257
Conversation
aborah-sudo
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increases the sleep duration from 2 to 5 seconds in vfido_passkey_with_output within sssd_test_framework/utils/authentication.py to accommodate longer IPA backend lookups during sequential authentication tests on fedora-43/rawhide. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
We have green run from : SSSD/sssd#8949 |
spoore1
left a comment
spoore1
left a comment
There was a problem hiding this comment.
I'm ok with this. The tests appear to be working from the checks here:
SSSD/sssd#8949
The 2-second sleep before vfido_touch was too short for IPA backend lookups on fedora-43/rawhide, causing the 3rd sequential passkey authentication to fail in test_passkey__su_user_same_key_for_other_users.
3 participants
The 2-second sleep before vfido_touch was too short for IPA backend lookups on fedora-43/rawhide, causing the 3rd sequential passkey authentication to fail in test_passkey__su_user_same_key_for_other_users.