Tests: No merge#8949
Conversation
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__register_sssctl()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__register_ipa()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__su_user()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__su_user_with_failed_pin()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__su_user_with_incorrect_mapping()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__su_user_when_server_is_not_resolvable()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__su_user_when_offline()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__lookup_user_from_cache()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__su_user_with_multiple_keys()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__su_user_same_key_for_other_users()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
…y_only()` Transform `test_passkey__check_passkey_mapping_token_as_ssh_key_only()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
…ping()` Transform `test_passkey__su_user_when_add_with_ssh_key_and_mapping()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__su_fips_fido_key()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__check_tgt()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__ipa_server_offline()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__su_with_12_mappings()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__su_no_pin_set()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__prompt_options()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Transform `test_passkey__su_fallback_to_password()` to use vfido instead of umockdev Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Now that passkey tests are using vfido this fixture was unnecessary Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Convert "not in" membership tests to pythonic style Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
The vhci-hcd kernel module is loaded at container runtime in Testing Farm, not during CI builds. This section was reverted in the ikerexxe branch but the cherry-pick was empty due to context changes.
No merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the passkey integration tests to use vfido instead of umockdev for virtual passkey testing, removing recorded device files and updating test cases to programmatically configure the virtual passkey service. It also updates package requirements and cleans up unused containers and hosts during test preparation. Feedback on these changes suggests pointing to the official upstream repository in requirements.txt instead of a personal fork, and using yq instead of fragile sed commands to modify docker-compose.yml.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| git+https://github.com/next-actions/pytest-tier | ||
| git+https://github.com/next-actions/pytest-output | ||
| git+https://github.com/SSSD/sssd-test-framework | ||
| git+https://github.com/aborah-sudo/sssd-test-framework@fix_vfdo |
There was a problem hiding this comment.
The dependency points to a personal fork (aborah-sudo/sssd-test-framework@fix_vfdo) instead of the official upstream repository (SSSD/sssd-test-framework). Referencing personal forks or development branches in requirements can lead to security risks, unmaintained dependencies, and build failures if the fork or branch is deleted or modified. Please update this to point to the official upstream repository.
git+https://github.com/SSSD/sssd-test-framework
| sed -i '/^ ipa2:/,/^ ldap:/{ /^ ldap:/!d; }' docker-compose.yml | ||
| sed -i '/^ kdc:/,/^ keycloak:/{ /^ keycloak:/!d; }' docker-compose.yml | ||
| sed -i '/^ keycloak:/,/^networks:/{ /^networks:/!d; }' docker-compose.yml |
There was a problem hiding this comment.
Using sed with range patterns to delete blocks in a YAML file (docker-compose.yml) is highly fragile and error-prone. YAML is hierarchical and indentation-sensitive; any change in the order of services or formatting will break these regex-based deletions or corrupt the file. Since yq is already installed and used elsewhere in this test suite, it is much safer and more robust to use yq to modify the YAML structure directly.
yq -i 'del(.services.ipa2, .services.kdc, .services.keycloak)' docker-compose.yml
2 participants
No description provided.