changed azure_rm_deployment properties.parameters type to object.#480
Conversation
|
@cmendible it looks like these files are auto-generated from ansible documentation, so I think it's best to go and fix the source on the ansible repo... it will break again when 2.6 is released! |
|
HI @carlbuchmann thanks for the pointer! I created this pull request in the ansible project: Added missing type for both template and parameters variables Question: If you merge this pull request, would it fix the current experience with the schemastore? |
|
@cmendible Thanks for looking into this, yes merging this PR should fix current problems. I'm adding the ability to the schema generator to work with overrides/fixes so that when I regenerate the schemas it will be fixed there as well. |
|
@shaded-enmity does that mean changes in the ansible repo (i.e. ansible/ansible#42033) will not be needed? |
|
@cmendible Keep the change and I'll scope out the type overrides for specific versions. Fixing the documentation strings is definitely a way to go :) |
|
Should I merge it? |
|
@madskristensen I would go for it as a temp fix... |
|
Thanks |
Hi @shaded-enmity and @madskristensen I was facing some ansible validation issues when using azure_rm_deployment. The schemas in the store specify that properties.parameters should be a string instead of object (it's a hash of all the variables).
I've created this pull request to try to fix this.
Hope it helps!