Skip to content

changed azure_rm_deployment properties.parameters type to object.#480

Merged
madskristensen merged 1 commit into
SchemaStore:masterfrom
cmendible:master
Jun 28, 2018
Merged

changed azure_rm_deployment properties.parameters type to object.#480
madskristensen merged 1 commit into
SchemaStore:masterfrom
cmendible:master

Conversation

@cmendible

Copy link
Copy Markdown
Contributor

Hi @shaded-enmity and @madskristensen I was facing some ansible validation issues when using azure_rm_deployment. The schemas in the store specify that properties.parameters should be a string instead of object (it's a hash of all the variables).

I've created this pull request to try to fix this.

Hope it helps!

@carlbuchmann

Copy link
Copy Markdown

@cmendible it looks like these files are auto-generated from ansible documentation, so I think it's best to go and fix the source on the ansible repo... it will break again when 2.6 is released!
"Auto-Generated JSON Schema for Ansible-stable 2.5 (https://github.com/shaded-enmity/ansible-schema-generator" - generate JSON schema for language servers from Ansible module documentation in an Ansible repository checkout target_path

@cmendible

Copy link
Copy Markdown
Contributor Author

HI @carlbuchmann thanks for the pointer! I created this pull request in the ansible project: Added missing type for both template and parameters variables

Question: If you merge this pull request, would it fix the current experience with the schemastore?

@shaded-enmity

Copy link
Copy Markdown
Contributor

@cmendible Thanks for looking into this, yes merging this PR should fix current problems. I'm adding the ability to the schema generator to work with overrides/fixes so that when I regenerate the schemas it will be fixed there as well.

@cmendible

Copy link
Copy Markdown
Contributor Author

@shaded-enmity does that mean changes in the ansible repo (i.e. ansible/ansible#42033) will not be needed?

@shaded-enmity

Copy link
Copy Markdown
Contributor

@cmendible Keep the change and I'll scope out the type overrides for specific versions. Fixing the documentation strings is definitely a way to go :)

@madskristensen

Copy link
Copy Markdown
Contributor

Should I merge it?

@cmendible

Copy link
Copy Markdown
Contributor Author

@madskristensen I would go for it as a temp fix...

@madskristensen
madskristensen merged commit 9d4d6b0 into SchemaStore:master Jun 28, 2018
@madskristensen

Copy link
Copy Markdown
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants