Skip to content

Conversation

@ehogan
Copy link
Contributor

@ehogan ehogan commented Dec 16, 2019

This pull request refactors the contents of regrid_area_weighted_rectilinear_src_and_grid. Tests for the __prepare and __perform functions will be considered in a future pull request related to updating AreaWeightedRegridder .

Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stephenworsley stephenworsley merged commit e5770ed into SciTools:area_weighted_regridding Dec 17, 2019
@ehogan ehogan deleted the refactor_regrid_area_weighted branch December 17, 2019 15:51
@abooton abooton changed the title Split regrid_area_weighted_rectilinear_src_and_grid into prepare and perform PI-2472: Split regrid_area_weighted_rectilinear_src_and_grid into prepare and perform Dec 24, 2019
abooton added a commit to abooton/iris that referenced this pull request Jan 9, 2020
* pr/3623:
  PI-2472:  Update area weighted regridder to accept different dim data (SciTools#3625)
  PI-2472: Fix issue related to comparison / equality in regridding code (SciTools#3624)
  Remove unused variables in regridding code (SciTools#3620)
  Add docstring and what's new (SciTools#3619)
  Move calculation of area weights from perform to prepare (SciTools#3617)
  PI-2472: Refactor AreaWeightedRegridder (SciTools#3606)
  Test for AreaWeightedRegridder (SciTools#3604)
  Split regrid_area_weighted_rectilinear_src_and_grid into prepare and perform (SciTools#3601)
abooton pushed a commit to abooton/iris that referenced this pull request Jan 9, 2020
…perform (SciTools#3601)

* Split regrid_area_weighted_rectilinear_src_and_grid into prepare and perform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants