PI-2472: Fix issue related to comparison / equality in regridding code #3624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abooton
changed the title
abooton
added a commit
to abooton/iris
that referenced
this pull request
Jan 9, 2020
* pr/3623: PI-2472: Update area weighted regridder to accept different dim data (SciTools#3625) PI-2472: Fix issue related to comparison / equality in regridding code (SciTools#3624) Remove unused variables in regridding code (SciTools#3620) Add docstring and what's new (SciTools#3619) Move calculation of area weights from perform to prepare (SciTools#3617) PI-2472: Refactor AreaWeightedRegridder (SciTools#3606) Test for AreaWeightedRegridder (SciTools#3604) Split regrid_area_weighted_rectilinear_src_and_grid into prepare and perform (SciTools#3601)
abooton
pushed a commit
to abooton/iris
that referenced
this pull request
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue originally reported via #3606.
When regridding a source cube that was used to create the regridder, the comparisons performed in
copy_coordsusingisare True. However, when regridding a source cube that was not used to create the regridder, the comparisons are False, leading to cubes that havelatitudeandlongitudecoordinates without names (see test failure for 6f2dcda).The solution is the one proposed in #3606.