feat(install): add project-local Cursor and Codex setup - #10
Merged
Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98d5684257
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
added 5 commits
June 8, 2026 01:47
Replace the `(is_local_install, enable_global_db)` boolean pair in the cursor and codex `install_mcp_server` helpers with a shared `InstallScope` enum (`Global` / `ProjectLocal`) so the two invalid combinations are unrepresentable and each agent maps the scope via an exhaustive match. Generated cursor `mcp.json` and codex `config.toml` remain byte-identical. Wire cursor, codex, and kiro hook-command construction to the shared `super::hook_command` helper instead of POSIX-only local quoting. POSIX output for cursor/codex is unchanged; on Windows hook commands are now double-quoted with normalized separators, fixing a latent quoting bug. This also clears the four recurring unused-code warnings for `hook_command`, `hook_command_for_platform`, `quote_windows_command_arg`, and `quote_posix_command_arg`.
`should_skip_agent_install_maintenance` was hardwired to always return true, leaving the `check_install_stale` gate and the silent-reinstall block unreachable. Re-enable them selectively: skip the implicit reinstall scan for `Serve` (the MCP hot path with a 30 s initialize timeout, #84), `Install` / `Reinstall` (already install), and `Tool` (per-invocation hot path), and run it for every other command so agent permissions, hooks, and MCP config re-sync after a binary upgrade. Update the startup test to assert the selective behavior (skip for serve/install/reinstall/tool; run for representative everyday commands).
Add `Uninstall` and `Doctor` to `should_skip_agent_install_maintenance`'s skip set, restoring the original CHANGELOG #84 intent: don't mutate agent configs during the read-only `doctor` diagnostic, and don't reinstall configs right before `uninstall` removes them. Update the selective-gate test to assert skip for both alongside serve/install/reinstall/tool, while still running maintenance for representative everyday commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Stack base for the memory and docs PRs.