Replace session memory with holographic fact store - #2
Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e86ef80b7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This reverts commit fca9582.
Flake ScriptedAlchemy#2: dashboard API tests (e.g. `automation_config_is_dashboard_controllable_and_persistent`, `automation_jobs_crud_and_manual_run_are_dashboard_controllable`) intermittently failed with `... failed: io: Peer disconnected` when the client raced the dashboard server's startup under parallel load. Fix (shared harness): the dashboard POST/PATCH/DELETE helpers now route through `common::http_call_with_retry`, so a request that fails at the connection level (peer disconnected / refused / reset) is retried with bounded backoff. Combined with `wait_for_dashboard` now polling for a real 2xx before the first request, all dashboard tests benefit. The local `git` helper also uses the resilient absolute-path lookup + ENOENT retry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 participant
Summary
amari-holographicFHRR vectors.tokensave_fact_store,tokensave_fact_feedback, andtokensave_memory_status, plus v11 migration/backfill from legacy memory tables.Verification
cargo testcargo clippy --workspace --all-targetscargo fmt --all -- --checkgit diff --checkact pull_request -W .github/workflows/ci.yml ...attempted; format passed aftercargo fmt, Linux test exposed an act/Docker-sensitive git config test which was fixed and then verified locally.