Skip to content

mruby use RANGE_* macros - #697

Merged
Quintus merged 2 commits into
Secretchronicles:develfrom
susnux:mruby-3
May 18, 2021
Merged

mruby use RANGE_* macros#697
Quintus merged 2 commits into
Secretchronicles:develfrom
susnux:mruby-3

Conversation

@susnux

@susnux susnux commented May 17, 2021

Copy link
Copy Markdown

Use RANGE_* macros to be independent of the RRange struct implementation.

Mostly relevant if using system's mruby.

Use RANGE_* macros to be independent of the RRange struct implementation.
@Quintus

Quintus commented May 17, 2021 via email

Copy link
Copy Markdown
Member

@Quintus

Quintus commented May 17, 2021 via email

Copy link
Copy Markdown
Member

@susnux

susnux commented May 17, 2021

Copy link
Copy Markdown
Author

I suppose this is because the mruby version included in TSC's source tree is too old.

You are right TSC currently ships 2.0.0, that macros were added with 2.0.1

Out of curiosity, are you packaging TSC for some Linux distribution?

Yes, for openSUSE ;-)

@susnux

susnux commented May 17, 2021

Copy link
Copy Markdown
Author

Once I get around to updating it I however see no reason why this should not be applied.

Pushed a commit which updates the submodule to latest 2.x release (2.1.2).
Some bugs got fixed, but no API breaking changes so this update should be safe.

On openSUSE we build with mruby 3.0.0, so you could also consider upgrade to 3.x release series.

@Quintus
Quintus merged commit 14e3c17 into Secretchronicles:devel May 18, 2021
@Quintus

Quintus commented May 18, 2021 via email

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants