Skip to content

Conversation

@jt-pham
Copy link

@jt-pham jt-pham commented Dec 3, 2019

I added some Remote WebDriver and DesiredCapabilities examples in Python

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

I added some Remote WebDriver and DesiredCapabilities examples in Python
@harsha509
Copy link
Member

Hi @jt-pham,

Can you please update the sample code in all the translated pages too.

Thanks!

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments, additionally, please add these code examples to the other translated files.

{{< code-panel language="python" >}}
# We don't have a Python code sample yet - Help us out and raise a PR
from selenium import webdriver
from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use DesiredCapabilities, you can follow the other examples and use FirefoxOptions

# We don't have a Python code sample yet - Help us out and raise a PR
# https://github.com/SeleniumHQ/selenium/wiki/DesiredCapabilities
from selenium import webdriver
from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

@diemol
Copy link
Member

diemol commented Dec 22, 2019

For all watchers, this PR has gone stale, if anyone wants to submit it again, feel free to do so and please give credit to the original author.

@harsha509
Copy link
Member

For all watchers, this PR has gone stale, if anyone wants to submit it again, feel free to do so and please give credit to the original author.

hi @jt-pham ,

Thanks for providing the PR.

As the PR gone stale now, I've updated the sample code in PR #153

diemol pushed a commit that referenced this pull request Dec 26, 2019
* Modify: Removed unneccessary awaits for find element

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Added ruby sample code for mouse actionsin support package

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Revamping the WebElement usage document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Adding findElements section to web_element document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Update to stale PR #111

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Removed desired capabilities and used FirefoxOptions in code sample

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

Co-authored-by: Manoj Kumar <manoj9788@gmail.com>
@diemol
Copy link
Member

diemol commented Dec 26, 2019

Replaced by #153

@diemol diemol closed this Dec 26, 2019
diemol pushed a commit that referenced this pull request Feb 8, 2020
…tions in detail (#212) [deploy site]

* Modify: Removed unneccessary awaits for find element

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Added ruby sample code for mouse actionsin support package

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Revamping the WebElement usage document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Adding findElements section to web_element document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Update to stale PR #111

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Removed desired capabilities and used FirefoxOptions in code sample

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] Introduction-> selenium_proj_and_tools

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] introduction-> types of testing

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Fix: Updating text to bold

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Ruby code samples for moveToElement and moveByOffset in mouse actions in detail

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

Co-authored-by: Manoj Kumar <manoj9788@gmail.com>
diemol pushed a commit that referenced this pull request Feb 9, 2020
…ase (#213) [deploy site]

* Modify: Removed unneccessary awaits for find element

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Added ruby sample code for mouse actionsin support package

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Revamping the WebElement usage document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Adding findElements section to web_element document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Update to stale PR #111

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Removed desired capabilities and used FirefoxOptions in code sample

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] Introduction-> selenium_proj_and_tools

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] introduction-> types of testing

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Fix: Updating text to bold

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Ruby code samples for dragAndDrop, dragAndDropBy and release

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

Co-authored-by: Manoj Kumar <manoj9788@gmail.com>
diemol added a commit that referenced this pull request Feb 10, 2020
#216) [deploy site]

* Modify: Removed unneccessary awaits for find element

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Added ruby sample code for mouse actionsin support package

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Revamping the WebElement usage document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Adding findElements section to web_element document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Update to stale PR #111

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Removed desired capabilities and used FirefoxOptions in code sample

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] Introduction-> selenium_proj_and_tools

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] introduction-> types of testing

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Fix: Updating text to bold

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: [JS], [py] code sample for clear command in keyboard doc

Co-authored-by: Manoj Kumar <manoj9788@gmail.com>
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
diemol added a commit that referenced this pull request Feb 12, 2020
…deploy site]

* Modify: Removed unneccessary awaits for find element

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Added ruby sample code for mouse actionsin support package

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Revamping the WebElement usage document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Adding findElements section to web_element document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Update to stale PR #111

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Removed desired capabilities and used FirefoxOptions in code sample

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] Introduction-> selenium_proj_and_tools

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] introduction-> types of testing

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Fix: Updating text to bold

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Ruby code sample for clear command

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

Co-authored-by: Manoj Kumar <manoj9788@gmail.com>
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
diemol added a commit that referenced this pull request Feb 13, 2020
…m standalone (#222) [deploy site]

* Modify: Removed unneccessary awaits for find element

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Added ruby sample code for mouse actionsin support package

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Revamping the WebElement usage document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Adding findElements section to web_element document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Update to stale PR #111

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Removed desired capabilities and used FirefoxOptions in code sample

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] Introduction-> selenium_proj_and_tools

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] introduction-> types of testing

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Fix: Updating text to bold

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] Selenium standalone installation

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

Co-authored-by: Manoj Kumar <manoj9788@gmail.com>
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
diemol pushed a commit that referenced this pull request Feb 20, 2020
* Modify: Removed unneccessary awaits for find element

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Added ruby sample code for mouse actionsin support package

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Revamping the WebElement usage document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Adding findElements section to web_element document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Update to stale PR #111

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Removed desired capabilities and used FirefoxOptions in code sample

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] Introduction-> selenium_proj_and_tools

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] introduction-> types of testing

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Fix: Updating text to bold

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Adding kotlin code samples for page load startegy

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

Co-authored-by: Manoj Kumar <manoj9788@gmail.com>
diemol added a commit that referenced this pull request Feb 20, 2020
… [deploy site]

* Modify: Removed unneccessary awaits for find element

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Added ruby sample code for mouse actionsin support package

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Revamping the WebElement usage document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Add: Adding findElements section to web_element document

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Update to stale PR #111

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Removed desired capabilities and used FirefoxOptions in code sample

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] Introduction-> selenium_proj_and_tools

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: Translated[EN-FR] introduction-> types of testing

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Fix: Updating text to bold

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

* Modify: [EN]->[FR]: Translating webdriver-> support classes

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>

Co-authored-by: Manoj Kumar <manoj9788@gmail.com>
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ diemol
❌ jt-pham
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants