Skip to content

Modify: PR for stale pr #111 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 26, 2019
Merged

Modify: PR for stale pr #111 #153

merged 10 commits into from
Dec 26, 2019

Conversation

@harsha509
Copy link
Member

@harsha509 harsha509 commented Dec 26, 2019 •
edited
Loading

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

harsha509 and others added 9 commits December 16, 2019 20:24
@harsha509
Modify: Removed unneccessary awaits for find element
41e5d3e 
Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
@harsha509
Add: Added ruby sample code for mouse actionsin support package
5051195 
Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
@harsha509
Merge branch 'master' of https://github.com/Harsha509/seleniumhq.gith…
b4bdbc5 
…ub.io
@harsha509
Modify: Revamping the WebElement usage document
4123fa2 
Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
@harsha509
Add: Adding findElements section to web_element document
381083d 
Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
@manoj9788
Merge branch 'master' into master
0c005f5
@harsha509
Merge branch 'master' of https://github.com/Harsha509/seleniumhq.gith…
21aabec 
…ub.io
@harsha509
Merge remote-tracking branch 'upstream/master'
f8dec4b
@harsha509
Modify: Update to stale PR #111
df1dbd8 
Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
@harsha509 harsha509 mentioned this pull request Dec 26, 2019
Closed
6 tasks
@harsha509
Modify: Removed desired capabilities and used FirefoxOptions in code …
a65dfa0 
…sample

Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
@harsha509
Copy link
Member Author

harsha509 commented Dec 26, 2019

Apologies, removed desiredCapabilities and used FirefoxOptions() for code samples.

diemol
diemol approved these changes Dec 26, 2019
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @harsha509!

@diemol diemol merged commit b59a3a2 into SeleniumHQ:master Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harsha509 @diemol @manoj9788