Skip to content

Conversation

@krmahadevan
Copy link
Contributor

  • Added details on how node types
  • Made some formatting changes to the docs.

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Enhanced the docs for customising a node and added details on how to use a regular jar via --ext argument.
Also added details on Node implementation types and their relevance

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@netlify
Copy link

netlify bot commented Nov 10, 2022

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit 244d633
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/636cdd4f94d8f10008dc5ce2
😎 Deploy Preview https://deploy-preview-1223--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@krmahadevan krmahadevan force-pushed the customized_node_doc_changes branch from 41a5abf to d74be79 Compare November 10, 2022 05:28
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, thank you.

@krmahadevan krmahadevan force-pushed the customized_node_doc_changes branch from 91fd7dc to 244d633 Compare November 10, 2022 11:15
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @krmahadevan!

@diemol diemol merged commit f9f1684 into SeleniumHQ:trunk Nov 10, 2022
@krmahadevan krmahadevan deleted the customized_node_doc_changes branch November 10, 2022 11:29
selenium-ci added a commit that referenced this pull request Nov 10, 2022
* Customize a node docs enhancement

* Added details on how node types
* Made some formatting changes to the docs.

* Removing the aliases

* Fixing the dependencies information

* Removed alias sections

[deploy site] f9f1684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants