Skip to content

Conversation

@krmahadevan
Copy link
Contributor

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@netlify
Copy link

netlify bot commented Apr 2, 2023

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit 63997c7
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/642af5e1253f5c00083532f7
😎 Deploy Preview https://deploy-preview-1352--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @krmahadevan!

@diemol diemol merged commit 7771c57 into SeleniumHQ:trunk Apr 3, 2023
@krmahadevan krmahadevan deleted the fix_customise_node_docs branch April 3, 2023 15:53
selenium-ci added a commit that referenced this pull request Apr 3, 2023
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>

[deploy site] 7771c57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants