Skip to content

Conversation

@boris779
Copy link
Contributor

@boris779 boris779 commented Jan 7, 2020

Updated german files. Due to some rebasing conflicts, it took me some time to do all the stuff.

Description

German translation of documentation

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

boris779 and others added 29 commits November 17, 2019 16:26
copied *.en.md to *.de.md files
Added German (de) and translated shortcuts
from contributing.en.md
for locating_elements
Quick Tour and Landing page
copied *.en.md to *.de.md files
for locating_elements
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
@claassistantio
Copy link

claassistantio commented Jan 7, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ boris779
✅ diemol
✅ Madh93
❌ selenium-ci
You have signed the CLA already but the status is still pending? Let us recheck it.

<link rel="icon" href="https://selenium.dev/documentation/de/images/favicon.png" type="image/png">

<title>Handling von Cookies :: Dokumentation für Selenium</title>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @boris779 ,

Other docs describe this page as 'working with cookies' and in the translated page, it says 'Handling cookies'. It should be 'Arbeiten mit Cookies' i think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, I will change that

title: "Maus"
weight: 11
---

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @boris779,
This section is removed from WebDriver and placed in support packages I think. This should be removed i think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course, I will remove that

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @boris779,

Thanks for the PR. At some places translated texts need to be changed when compared to other docs (These are minor) But need to remove mouse.de.md from webdriver section

Thanks,
Harsha

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @boris779,
Thank you for this PR, but it has changes in 631 files❗️We really prefer small PRs.
Could you please fix the commit history so we only need to review the affected files for the German translation?

@boris779
Copy link
Contributor Author

Hi @diemol!

I have no idea how that could happen. While rebasing a lot of conflicts are shown.
How can I fix the commit history? (Never done before)

What I learned from this commit is to immediately push every translation so that should never happen again.

@boris779
Copy link
Contributor Author

Sorry I do not see a chance to fix that PR.
I will close it and try it again.

@boris779 boris779 closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants