Skip to content

Conversation

@kzhirata
Copy link
Contributor

Description

Add Japanese translation of
#327
#326

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @kzhirata,

Thanks for the PR. I've made one suggestion. Can you please look into it.

Thanks,
Harsha

certificate problems. If set to `true`, invalid certificate will be
trusted by the browser.
機能が `false` に設定されている場合、ナビゲーションでドメイン証明書の問題が発生すると、
[insecure certificate error](//developer.mozilla.org/de/docs/Web/WebDriver/Errors/InsecureCertificate) が返されます。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[insecure certificate error](//developer.mozilla.org/de/docs/Web/WebDriver/Errors/InsecureCertificate) が返されます。
[insecure certificate error](//developer.mozilla.org/ja/docs/Web/WebDriver/Errors/InsecureCertificate) が返されます。

harsha509
harsha509 previously approved these changes Mar 19, 2020
@kzhirata
Copy link
Contributor Author

@harsha509 Thank you for reviewing. I've fixed the links.

@harsha509
Copy link
Member

@harsha509 Thank you for reviewing. I've fixed the links.

Thanks for updating the links to the translated pages too!

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kzhirata!

@diemol diemol merged commit 13b79c0 into SeleniumHQ:master Mar 19, 2020
@kzhirata kzhirata deleted the types_of_testing branch March 19, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants