Skip to content

Add Spanish translation to sites and fix #237 #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 18, 2020
Merged

Add Spanish translation to sites and fix #237 #327

merged 4 commits into from
Mar 18, 2020

Conversation

@ivanrodjr
Copy link
Contributor

@ivanrodjr ivanrodjr commented Mar 17, 2020

Description

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@ivanrodjr
Add spanish translation
461e48c 
- Translated 'on test automation' to spanish
@ivanrodjr
Add spanish translation to types of testing
361fe5b 
- Fixes SeleniumHQ#237
- Added translation notice to same file in langs fr, ja
harsha509
harsha509 approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

harsha509
harsha509 requested changes Mar 17, 2020
View reviewed changes
ivanrodjr and others added 2 commits March 17, 2020 23:44
@ivanrodjr
Add english translation to other types of testing langs
05a66a7 
- Added types of testing translation to the other lang sites
- Fix typo
@diemol
Merge branch 'master' into spanish-translation
e2337a7
diemol
diemol approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @ivanrodjr!

@diemol diemol merged commit a676648 into SeleniumHQ:master Mar 18, 2020
@ivanrodjr ivanrodjr deleted the spanish-translation branch March 18, 2020 18:40
@kzhirata kzhirata mentioned this pull request Mar 19, 2020
Merged
6 tasks
diemol added a commit that referenced this pull request Mar 19, 2020
@kzhirata @diemol
Add Japanese translation of the PRs below (#336)
13b79c0 
* Add Japanese translation of the PRs below

#327
#326

* fix link

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harsha509 harsha509 harsha509 requested changes

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivanrodjr @diemol @harsha509