Skip to content

Conversation

@hiroksarker
Copy link
Contributor

DesiredCapabilities , Local file detector using C#

DesiredCapabilities , Local file detector using C#
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hiroksarker, thanks for this PR.

Can you please make the changes also in the following files?

docs_source_files/content/remote_webdriver/remote_webdriver_client.fr.md docs_source_files/content/remote_webdriver/remote_webdriver_client.nl.md
docs_source_files/content/remote_webdriver/remote_webdriver_client.es.md docs_source_files/content/remote_webdriver/remote_webdriver_client.ja.md docs_source_files/content/remote_webdriver/remote_webdriver_client.zh-cn.md

These changes should be part of this PR as well. Thank you.

@hiroksarker hiroksarker requested a review from diemol October 29, 2019 03:15
@diemol
Copy link
Member

diemol commented Oct 29, 2019

Hi @hiroksarker, did you have the chance to check my previous comment?

@hiroksarker
Copy link
Contributor Author

@diemol yes, following files translation completed.

@diemol
Copy link
Member

diemol commented Oct 30, 2019

Not really @hiroksarker, only the English version of the file is changed, what about the other ones?

@hiroksarker
Copy link
Contributor Author

@diemol all translations competed. Would you please check it!

@jimevans
Copy link
Member

jimevans commented Nov 5, 2019

@diemol Please do not merge this docs change until the C# examples no longer refer to DesiredCapabilities.

@diemol
Copy link
Member

diemol commented Nov 5, 2019

I won't @jimevans, thanks for the heads up though.
I think I will make the changes myself and use:

            chromeOptions.BrowserVersion = "67";
            chromeOptions.PlatformName = "Windows XP";

I'll also remove the DesiredCapabilities text.

@diemol diemol merged commit c0f3224 into SeleniumHQ:master Nov 6, 2019
diemol pushed a commit that referenced this pull request Dec 7, 2019
…[deploy site]

* Completing the translation completed C#

Completing the translation completed C#

* Completing the translation

Completing the translation browser_navigation

* Completing the translation for #53

Completing the translation for #53

* Completing the translation for #52

Completing the translation for #52

* Add: Added c# sample code for keyup action

* Add: Added JavaScript sample code for remote_webdriver_client

* Add: Added JavaScript (Local file detector) for remote_webdriver_client

* Transaltion (Local file detector) for remote_webdriver_client.zh-cn

* Translation typo

* Code considering chrome/firefox drivers

* Change driver options calling

* Code Optimize Remote WebDriver Client

* Browser Options Example Change

* To avoid InsecureCertificateError and follow similar example

* set desiredcapabilities using javascript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants