Add: Added JavaScript sample code for remote_webdriver_client #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsha509
reviewed
Dec 5, 2019
docs_source_files/content/remote_webdriver/remote_webdriver_client.en.md
Outdated
Show resolved
Hide resolved
diemol
requested changes
Dec 5, 2019
docs_source_files/content/remote_webdriver/remote_webdriver_client.en.md
Outdated
Show resolved
Hide resolved
docs_source_files/content/remote_webdriver/remote_webdriver_client.en.md
Outdated
Show resolved
Hide resolved
diemol
requested changes
Dec 6, 2019
docs_source_files/content/remote_webdriver/remote_webdriver_client.de.md
Outdated
Show resolved
Hide resolved
diemol
requested changes
Dec 6, 2019
docs_source_files/content/remote_webdriver/remote_webdriver_client.de.md
Outdated
Show resolved
Hide resolved
diemol
requested changes
Dec 7, 2019
| (async function helloSelenium() { | ||
| let driver = new Builder() | ||
| //Browser Window Size Set | ||
| .setChromeOptions(new chrome.Options().windowSize({ width, height })) |
There was a problem hiding this comment.
I am really sorry, perhaps I have not been clear 😢
The other examples are living through the idea of: suppose you wanted to run Chrome on Windows XP using Chrome version 67...
So, if we see the Java example, it is using ChromeOptions to set those values. It would be nice to see the JavaScript example do the same thing, to keep uniformity. We do not need to set a window size or headless option, it is to make all the examples in different languages do the same.
Does it make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist