Skip to content

Conversation

@hiroksarker
Copy link
Contributor

Working with select elements using C#

Working with select elements using C#
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiroksarker would it be possible to have this in the other files? I mean, we cannot merge it like this. The same thing is happening in #51, it is just to copy the same code example to the other files that already translated.

Change Working with select elements C#
@hiroksarker hiroksarker requested a review from diemol October 28, 2019 12:38
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the example code to the other translated files? For example
docs_source_files/content/support_packages/working_with_select_elements.es.md and other ones...

@hiroksarker hiroksarker requested a review from diemol October 28, 2019 15:42
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hiroksarker,

Please include this change in the following files as well:
docs_source_files/content/support_packages/working_with_select_elements.fr.md docs_source_files/content/support_packages/working_with_select_elements.nl.md
docs_source_files/content/support_packages/working_with_select_elements.es.md docs_source_files/content/support_packages/working_with_select_elements.ja.md docs_source_files/content/support_packages/working_with_select_elements.zh-cn.md

These changes should be part of this PR as well. Thank you.

@diemol
Copy link
Member

diemol commented Oct 29, 2019

@hiroksarker did you have a look to my previous comment?

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiroksarker thanks for contributing, I completed the changes myself, the idea is to have all related code examples for all translated languages in the same pull request.
Please take that into account for future PRs.

@diemol diemol merged commit 2eba263 into SeleniumHQ:master Nov 6, 2019
diemol pushed a commit that referenced this pull request Dec 7, 2019
…[deploy site]

* Completing the translation completed C#

Completing the translation completed C#

* Completing the translation

Completing the translation browser_navigation

* Completing the translation for #53

Completing the translation for #53

* Completing the translation for #52

Completing the translation for #52

* Add: Added c# sample code for keyup action

* Add: Added JavaScript sample code for remote_webdriver_client

* Add: Added JavaScript (Local file detector) for remote_webdriver_client

* Transaltion (Local file detector) for remote_webdriver_client.zh-cn

* Translation typo

* Code considering chrome/firefox drivers

* Change driver options calling

* Code Optimize Remote WebDriver Client

* Browser Options Example Change

* To avoid InsecureCertificateError and follow similar example

* set desiredcapabilities using javascript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants